Skip to content

[#390] c cxx examples #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Oct 9, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #390

@elfenpiff elfenpiff self-assigned this Oct 9, 2024
@elfenpiff elfenpiff force-pushed the iox2-390-c-cxx-examples branch 3 times, most recently from 2fdc7bf to 7f27b9b Compare October 9, 2024 13:17
orecham
orecham previously approved these changes Oct 9, 2024
Copy link
Contributor

@orecham orecham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

EDIT: Just gotta fix the markdown issue 😆

@elfenpiff elfenpiff force-pushed the iox2-390-c-cxx-examples branch from dc1f2e6 to 66f656f Compare October 9, 2024 14:20
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (cff32dc) to head (1436d6a).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   78.90%   78.99%   +0.08%     
==========================================
  Files         196      196              
  Lines       23373    23373              
==========================================
+ Hits        18443    18463      +20     
+ Misses       4930     4910      -20     
Files with missing lines Coverage Δ
iceoryx2/src/config.rs 71.63% <100.00%> (ø)

... and 7 files with indirect coverage changes

@elfenpiff elfenpiff requested a review from orecham October 9, 2024 16:38
@elfenpiff elfenpiff merged commit ca22976 into eclipse-iceoryx:main Oct 9, 2024
51 of 55 checks passed
@elfenpiff elfenpiff deleted the iox2-390-c-cxx-examples branch October 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iceoryx WaitSet integration
2 participants