Skip to content

[#349] Bazel for Rust crates #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 8, 2024

Notes for Reviewer

This PR introduces rules_rust for the bazel build and makes the foreign_cc based approach obsolete. For now, bazel supports only Linux.

With the port to rules_rust, the build is now also fully sandboxed.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #349

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (a684249) to head (baec928).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   79.16%   79.12%   -0.04%     
==========================================
  Files         196      196              
  Lines       23540    23540              
==========================================
- Hits        18635    18627       -8     
- Misses       4905     4913       +8     
Files with missing lines Coverage Δ
iceoryx2-pal/posix/src/lib.rs 58.82% <ø> (ø)

... and 9 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox2-349-bazel-for-rust-crates branch 7 times, most recently from 9b7981b to 23866b5 Compare October 11, 2024 18:03
@elBoberido elBoberido force-pushed the iox2-349-bazel-for-rust-crates branch from 258d666 to cb20f76 Compare October 11, 2024 18:47
@elBoberido elBoberido force-pushed the iox2-349-bazel-for-rust-crates branch from cb20f76 to baec928 Compare October 11, 2024 19:56
@elBoberido elBoberido changed the title [WIP] [#349] Bazel for Rust crates [#349] Bazel for Rust crates Oct 11, 2024
@elBoberido elBoberido self-assigned this Oct 11, 2024
When working with Bazel and Cargo in this project, ensure the following steps are
followed to maintain consistency between both build systems:

### Adding Crates to Targets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to link this somewhere as publicly as possible. Maybe as a hint that plops up when the bazel CI pipeline fails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an FAQ for developers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elfenpiff Do you have an idea where to place it? doc/FAQ.md? I will add this in a follow up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elBoberido how about GITROOT/DEV_FAQ.md

@elBoberido elBoberido merged commit a48cd97 into eclipse-iceoryx:main Oct 14, 2024
54 checks passed
@elBoberido elBoberido deleted the iox2-349-bazel-for-rust-crates branch October 14, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants