-
Notifications
You must be signed in to change notification settings - Fork 62
[#349] Bazel for Rust crates #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#349] Bazel for Rust crates #452
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 79.16% 79.12% -0.04%
==========================================
Files 196 196
Lines 23540 23540
==========================================
- Hits 18635 18627 -8
- Misses 4905 4913 +8
|
9b7981b
to
23866b5
Compare
258d666
to
cb20f76
Compare
cb20f76
to
baec928
Compare
When working with Bazel and Cargo in this project, ensure the following steps are | ||
followed to maintain consistency between both build systems: | ||
|
||
### Adding Crates to Targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to link this somewhere as publicly as possible. Maybe as a hint that plops up when the bazel CI pipeline fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an FAQ for developers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elfenpiff Do you have an idea where to place it? doc/FAQ.md
? I will add this in a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elBoberido how about GITROOT/DEV_FAQ.md
Notes for Reviewer
This PR introduces
rules_rust
for the bazel build and makes theforeign_cc
based approach obsolete. For now, bazel supports only Linux.With the port to
rules_rust
, the build is now also fully sandboxed.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #349