-
Notifications
You must be signed in to change notification settings - Fork 62
[#390] waitset #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#390] waitset #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a break before reviewing the waitset test. Everything else is reviewed. Looks good.
f8d78ad
to
f527f61
Compare
…latform supports them; ensure that the fd set cannot attach the same fd twice
…umber of notifications
…quired when duration_until_next_deadline returned Duration::ZERO
4d73982
to
0c7ca92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intermediate result
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 78.97% 79.00% +0.03%
==========================================
Files 195 196 +1
Lines 22836 23251 +415
==========================================
+ Hits 18034 18369 +335
- Misses 4802 4882 +80
|
…hen reactor is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the only thing left complaining about is naming :)
… corrupted fdset in select on spurious wakeup on windows
405525b
to
ac53178
Compare
ac53178
to
5904a48
Compare
Notes for Reviewer
iceoryx2_cal::reactor
select
,epoll
orio_uring
multiplexingNodeEvent
was renamed intoWaitEvent
to signal to the user thatNode::wait()
will utilize an internalWaitSet
(in the future)Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #390