[#4] Update contributors #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfenpiff
approved these changes
Sep 25, 2024
elBoberido
reviewed
Sep 25, 2024
Comment on lines
+460
to
+464
| ## Thanks To All Contributors Of This Version | ||
|
|
||
| * [Christian »elfenpiff« Eltzschig](https://github.com/elfenpiff) | ||
| * [Mathias »elBoberido« Kraus](https://github.com/elboberido) | ||
| * [»orecham«](https://github.com/orecham) |
There was a problem hiding this comment.
This one can actually be autogenerated when doing the release on github
@elfenpiff what do you think? Shall we have a dedicated one?
There was a problem hiding this comment.
@elBoberido Clicked merge a nanosecond before the notification for this came 😅 . Although, it seems it was late.
There was a problem hiding this comment.
No problem. Just thought it would be easier for upcoming releases to use the automation.
I also realized that the heading on the main README should probably be
Thanks to the core contributors
Once we have more irregular contributions, it would make more sense
Comment on lines
+375
to
+378
| <td align="center" valign="top" width="14.28%"> | ||
| <a href="https://github.com/orecham"> | ||
| <img src="https://avatars.githubusercontent.com/u/8487595" width="120px;" alt="»orecham«"/><br /> | ||
| <sub><b>»orecham«</b></sub></a></td> |
There was a problem hiding this comment.
You definitely deserved it 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Adding self to contributors.
Pre-Review Checklist for the PR Author
Every source code file has a copyright header withSPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)Tests follow the best practice for testingChangelog updated in the unreleased section including API breaking changestask-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates #4