Skip to content

[#210] Initial setup for C language binding #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 1, 2024

Notes for Reviewer

This PR creates the initial setup for the C language bindings

  • build the actual package on all supported platforms
  • build the examples (in tree and out-of-tree)
  • CI setup

I still need to add some content to the readmes

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #210

@elfenpiff
Copy link
Contributor

@elBoberido I tested it and everything works great. The first step into C land feels great.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 116 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (dcfaf01) to head (ec4701c).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   79.71%   79.27%   -0.45%     
==========================================
  Files         186      190       +4     
  Lines       20575    20943     +368     
==========================================
+ Hits        16401    16602     +201     
- Misses       4174     4341     +167     
Files Coverage Δ
iceoryx2-ffi/ffi/src/lib.rs 0.00% <0.00%> (ø)
iceoryx2-ffi/ffi/src/subscriber.rs 0.00% <0.00%> (ø)
iceoryx2-ffi/ffi/src/publisher.rs 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

@elBoberido elBoberido changed the title [WIP] iox2-#210 Create c language binding [WIP] [#210] Create c language binding Jun 2, 2024
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch 2 times, most recently from 13c08d6 to 981c0fa Compare June 10, 2024 21:17
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch 3 times, most recently from 774e71d to 06adfcc Compare June 11, 2024 00:17
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch 4 times, most recently from 1bcfc3f to 9994f7a Compare June 12, 2024 23:19
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch 10 times, most recently from a2c046f to 9cf49f5 Compare June 14, 2024 01:55
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch from 9cf49f5 to b989026 Compare June 14, 2024 01:56
elfenpiff
elfenpiff previously approved these changes Jun 14, 2024
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great out of the box. I reviewed every file again to find something to criticize, but it is perfect.

@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch 8 times, most recently from ec4eeb2 to b5a18c9 Compare June 14, 2024 13:23
@elBoberido elBoberido force-pushed the iox2-210-create-c-language-binding branch from b5a18c9 to ec4701c Compare June 14, 2024 13:40
@elBoberido elBoberido requested a review from elfenpiff June 14, 2024 14:28
@elBoberido elBoberido merged commit 1f5c8a3 into eclipse-iceoryx:main Jun 14, 2024
45 of 51 checks passed
@elBoberido elBoberido deleted the iox2-210-create-c-language-binding branch June 14, 2024 14:35
@elBoberido elBoberido linked an issue Sep 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create C language binding
2 participants