Skip to content

[#200] Add 32bit atomic feature flag #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented May 20, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #200

@elfenpiff elfenpiff requested a review from elBoberido May 20, 2024 18:08
@elfenpiff elfenpiff self-assigned this May 20, 2024
elBoberido
elBoberido previously approved these changes May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (7618991) to head (a87b6c0).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   79.11%   79.61%   +0.49%     
==========================================
  Files         183      183              
  Lines       20420    20420              
==========================================
+ Hits        16156    16257     +101     
+ Misses       4264     4163     -101     
Files Coverage Δ
iceoryx2-pal/concurrency-sync/src/iox_atomic.rs 96.19% <ø> (ø)

... and 15 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 7c098cd into eclipse-iceoryx:main May 20, 2024
48 of 49 checks passed
@elfenpiff elfenpiff deleted the iox2-200-32-bit-atomic-flag branch May 20, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce atomic type for iceoryx
2 participants