Skip to content

[#200] integrate iox atomic #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented May 10, 2024

Notes for Reviewer

  • Integrates IoxAtomic
  • Add x86_32 bit github CI target to verify that 32-bit is working

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relatex to #200

@elfenpiff elfenpiff requested a review from elBoberido May 10, 2024 16:26
@elfenpiff elfenpiff self-assigned this May 10, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 79.14%. Comparing base (82b1baf) to head (8a3fdbc).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   79.23%   79.14%   -0.09%     
==========================================
  Files         183      183              
  Lines       20415    20420       +5     
==========================================
- Hits        16175    16161      -14     
- Misses       4240     4259      +19     
Files Coverage Δ
iceoryx2-bb/container/src/queue.rs 88.15% <100.00%> (ø)
iceoryx2-bb/container/src/vec.rs 90.54% <100.00%> (ø)
iceoryx2-bb/elementary/src/bump_allocator.rs 86.36% <100.00%> (ø)
iceoryx2-bb/elementary/src/package_version.rs 100.00% <100.00%> (ø)
iceoryx2-bb/elementary/src/relocatable_ptr.rs 100.00% <100.00%> (ø)
iceoryx2-bb/elementary/src/unique_id.rs 100.00% <100.00%> (ø)
iceoryx2-bb/lock-free/src/mpmc/bit_set.rs 95.42% <100.00%> (ø)
iceoryx2-bb/lock-free/src/mpmc/container.rs 95.59% <100.00%> (ø)
iceoryx2-bb/lock-free/src/mpmc/unique_index_set.rs 85.99% <100.00%> (+1.22%) ⬆️
...oryx2-bb/lock-free/src/spmc/unrestricted_atomic.rs 87.65% <100.00%> (ø)
... and 38 more

... and 6 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-200-integrate-iox-atomic branch 4 times, most recently from 016ebf6 to 8a3fdbc Compare May 16, 2024 23:31
@elfenpiff elfenpiff merged commit b53043d into eclipse-iceoryx:main May 17, 2024
46 of 49 checks passed
@elfenpiff elfenpiff deleted the iox2-200-integrate-iox-atomic branch May 17, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants