Skip to content

[#4] prepare documentation for release #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 17, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #4

@elfenpiff elfenpiff requested a review from elBoberido April 17, 2024 13:16
@elfenpiff elfenpiff self-assigned this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 78.56%. Comparing base (b0a28c6) to head (ea11d0b).

❗ Current head ea11d0b differs from pull request most recent head aee0283. Consider uploading reports for the commit aee0283 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   78.64%   78.56%   -0.08%     
==========================================
  Files         181      181              
  Lines       19922    19933      +11     
==========================================
- Hits        15667    15660       -7     
- Misses       4255     4273      +18     
Files Coverage Δ
iceoryx2-bb/container/src/byte_string.rs 89.78% <ø> (ø)
iceoryx2-bb/container/src/vec.rs 90.54% <100.00%> (ø)
iceoryx2-bb/posix/src/directory.rs 62.55% <ø> (ø)
iceoryx2-bb/posix/src/message_queue.rs 76.62% <ø> (ø)
...c/dynamic_storage/dynamic_storage_configuration.rs 66.00% <ø> (ø)
iceoryx2-cal/src/named_concept.rs 78.84% <ø> (ø)
iceoryx2/src/iox2.rs 0.00% <ø> (ø)
iceoryx2/src/port/port_identifiers.rs 87.50% <ø> (ø)
iceoryx2/src/port/publisher.rs 82.89% <100.00%> (ø)
iceoryx2/src/sample.rs 70.83% <ø> (ø)
... and 12 more

... and 4 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-4-prepare-documentation-for-release branch from 9c404e1 to 065c30b Compare April 17, 2024 14:05
@elfenpiff elfenpiff force-pushed the iox2-4-prepare-documentation-for-release branch from 065c30b to 2d32aeb Compare April 17, 2024 14:39
@elfenpiff elfenpiff requested a review from elBoberido April 18, 2024 09:20
elBoberido
elBoberido previously approved these changes Apr 18, 2024
@elfenpiff elfenpiff force-pushed the iox2-4-prepare-documentation-for-release branch from ea11d0b to aee0283 Compare April 18, 2024 11:37
@elfenpiff elfenpiff requested a review from elBoberido April 18, 2024 11:37
@elfenpiff elfenpiff merged commit 0ba4419 into eclipse-iceoryx:main Apr 18, 2024
41 of 45 checks passed
@elfenpiff elfenpiff deleted the iox2-4-prepare-documentation-for-release branch April 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants