Skip to content

Warning regarding default config is misleading #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elBoberido opened this issue Oct 6, 2024 · 1 comment · Fixed by #438
Closed

Warning regarding default config is misleading #437

elBoberido opened this issue Oct 6, 2024 · 1 comment · Fixed by #438
Assignees
Labels
bug Something isn't working

Comments

@elBoberido
Copy link
Member

Required information

Operating system:

any

Rust version:

any

Cargo version:

any

iceoryx2 version:
E.g. v1.2.3 or main branch

  • v0.4.1
  • main

Detailed log output:

        2 [W] "Config::global_config()"
              | Default config file found but unable to read data, populate config with default values.

Observed result or behaviour:

When running an iceoryx2 application, it looks for config/iceoryx2.toml. When it is not found, it prints the warning from above. This is misleading, since the config is not found.

Expected result or behaviour:

The warning should not be printed when the config file was not found but only when it was found and and could not be read.

Conditions where it occurred / Performed steps:

Create an out-of-tree iceoryx2 application and run it.

@elBoberido elBoberido added the bug Something isn't working label Oct 6, 2024
@elBoberido
Copy link
Member Author

Furthermore, it looks at a relative path to where the application is started. This is also error prone since the application might behave differently when launched from different locations. I'll open a separate issue for this if you agree that it should be changed.

@elBoberido elBoberido self-assigned this Oct 6, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Oct 6, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Oct 6, 2024
elBoberido added a commit that referenced this issue Oct 6, 2024
…ng-related-to-default-config-file

[#437] Fix misleading warning related to default config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant