-
Notifications
You must be signed in to change notification settings - Fork 421
Iox #27 client port implementation and test part 1 #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #27 client port implementation and test part 1 #858
Conversation
int64_t m_sequenceId{0}; | ||
}; | ||
|
||
class RequestHeader : public RpcBaseHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we have the rule of one class per file, but these are closely related and therefore I ask for an exception of this rule for these header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your exception will be granted if you grant me one favor which I may ask for in the future.
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 74.84% 74.82% -0.03%
==========================================
Files 332 334 +2
Lines 11936 12017 +81
Branches 2007 2017 +10
==========================================
+ Hits 8934 8992 +58
- Misses 2228 2253 +25
+ Partials 774 772 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
iceoryx_posh/include/iceoryx_posh/internal/popo/ports/client_port_user.hpp
Show resolved
Hide resolved
d218bd0
to
bfdf877
Compare
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
13c0a46
a17ed45
to
13c0a46
Compare
Signed-off-by: Mathias Kraus <[email protected]>
13c0a46
to
c210a13
Compare
@FerdinandSpitzschnueffler @elfenpiff rebased on master to get the plantuml documentation to this branch and adjusted it to the changes from this branch |
@elfenpiff @FerdinandSpitzschnueffler I mentioned to merge this only once the follow up PR with the tests is ready. I already opened a draft PR for the The diff is quite large if this is not merged. |
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This is a first PR to implement the design for request-response and does some refactoring of the current code, introduces some common classes and finalizes the
ClientPortUser
. Since it got bigger than anticipated, theClientPortRouDi
and the tests for theClientPortUser/-RouDi
will be done in the next PR to keep the PR somewhat small. I will merge this PR only once the next PR with the full tests and the finishedClientPortRouDi
class is ready for review.Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References