-
Notifications
You must be signed in to change notification settings - Fork 421
iox-#743 Set all documentation links to v2.0.0
#1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#743 Set all documentation links to v2.0.0
#1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a single link is working since the tag v2.0.0
does not exist.
The better approach would be that every link points to the release_2.0
branch.
With source code we already have the approach that with every PR everything has to work always. I think we should stick to this strategy also for documentation
@elfenpiff Thanks for review! I don't understand how using the |
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Marika Lehmann <[email protected]>
1d7c0ca
to
ad37027
Compare
Codecov Report
@@ Coverage Diff @@
## release_2.0 #1254 +/- ##
===============================================
+ Coverage 78.91% 78.94% +0.02%
===============================================
Files 370 370
Lines 14706 14706
Branches 2059 2059
===============================================
+ Hits 11605 11609 +4
+ Misses 2419 2417 -2
+ Partials 682 680 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could all commits be squashed with a commit message to indicate setting the version to v2.0.0? This makes it easier to drop the commit when the changes from the release branch are merged back to master
Signed-off-by: Marika Lehmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are more changes than just setting the links to v2.0.0
dropping commits might not be a good idea. Luckily it should be easy to do a mass search and replace.
Pre-Review Checklist for the PR Author
Code follows the coding style of CONTRIBUTING.mdTests follow the best practice for testingChangelog updated in the unreleased section including API breaking changesiox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
v2.0.0
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References