Skip to content

Iox #27 add client and server examples [stacked PR #6] #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 28, 2022
Merged

Iox #27 add client and server examples [stacked PR #6] #1112

merged 15 commits into from
Feb 28, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Feb 15, 2022 •
edited by dkroenke
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

This PR add examples for the typed and untyped API for the Client and Server

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the example providing example for a specific feature label Feb 15, 2022
@elBoberido elBoberido self-assigned this Feb 15, 2022
@elBoberido elBoberido linked an issue Feb 15, 2022 that may be closed by this pull request
Request/Response communication with iceoryx #27
Closed
22 tasks
@elBoberido elBoberido changed the base branch from master to iox-#27-add-typed-client-and-server-api February 15, 2022 19:04
@elBoberido elBoberido changed the title Iox #27 add client and server examples [stacked PR #5] Iox #27 add client and server examples [stacked PR #6] Feb 15, 2022
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 43d6216 to b74bb56 Compare February 15, 2022 19:48
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch 2 times, most recently from 10022e2 to eed893a Compare February 15, 2022 23:38
@dkroenke dkroenke self-requested a review February 16, 2022 13:34
@dkroenke dkroenke force-pushed the iox-#27-add-client-and-server-examples branch 2 times, most recently from 8ea5026 to 4196963 Compare February 16, 2022 17:22
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from ec23db3 to 26be415 Compare February 16, 2022 17:53
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 4196963 to 82b6680 Compare February 16, 2022 17:54
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 26be415 to 2795dc6 Compare February 17, 2022 15:04
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 82b6680 to 7ec908c Compare February 17, 2022 15:05
@dkroenke dkroenke force-pushed the iox-#27-add-client-and-server-examples branch from e1c77b1 to d2dc7ac Compare February 17, 2022 19:19
@dkroenke dkroenke marked this pull request as ready for review February 17, 2022 19:21
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 4a9140d to f1c73d8 Compare February 17, 2022 19:44
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 2795dc6 to 401c75f Compare February 18, 2022 16:45
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 642c8e3 to 342183c Compare February 18, 2022 16:45
@budrus budrus requested review from budrus and removed request for dkroenke February 20, 2022 18:46
budrus
budrus requested changes Feb 20, 2022
View reviewed changes
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 19e189f to 9ddb014 Compare February 21, 2022 11:09
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 342183c to 05e0b15 Compare February 21, 2022 11:10
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch 2 times, most recently from 04cde7d to 128cb6f Compare February 21, 2022 18:07
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 05e0b15 to be0fabe Compare February 21, 2022 18:35
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 078ac6a to b02a50f Compare February 21, 2022 20:07
@dkroenke dkroenke force-pushed the iox-#27-add-client-and-server-examples branch from 213de72 to fb3d563 Compare February 28, 2022 12:10
budrus
budrus previously approved these changes Feb 28, 2022
View reviewed changes
dkroenke and others added 15 commits February 28, 2022 15:30
@dkroenke @elBoberido
iox-#27 Add Client/Server example
21c8d0b 
Signed-off-by: Dietrich Krönke <[email protected]>
@dkroenke @elBoberido
iox-#27 Integrationtest Request Response Example
000b4e1
@dkroenke @elBoberido
iox-#27 Add Request/Response to examples doc
73c2ba5
@dkroenke @elBoberido
iox-#27 Add Readme for request response example
fa07f5f
@elBoberido
iox-#27 Update release notes
d7f5b53
@dkroenke @elBoberido
iox-#27 Fix documentation findings
2a6032d 
Signed-off-by: Dietrich Krönke <[email protected]>
@dkroenke @elBoberido
iox-#27 Rewrite listener example client to use waitset
4e24385 
Signed-off-by: Dietrich Krönke <[email protected]>
@elBoberido
iox-#27 Implement stream operator for ClientSendError and ServerSendE…
16c6daa 
…rror
@elBoberido
iox-#27 Add tests for ClientSendError and ServerSendError string conv…
722cc75 
…ersion
@elBoberido
iox-#27 Remove static_cast for enums which have a stream operator imp…
3af5818 
…lemented
@elBoberido
iox-#27 Print warning when request or response could not be sent
e2da7a0
@elBoberido
iox-#27 Fix README findings
aff0a13
@elBoberido
iox-#27 Sync example code with README
89095da
@dkroenke @elBoberido
iox-#27 Add example page for req/res example to website
de22b43 
Signed-off-by: Dietrich Krönke <[email protected]>
@dkroenke @elBoberido
iox-#27 Correct entry in examples markdown
a82f406
@elBoberido elBoberido force-pushed the iox-#27-add-client-and-server-examples branch from 9d8d666 to a82f406 Compare February 28, 2022 14:30
@dkroenke dkroenke merged commit 1d7366b into master Feb 28, 2022
@dkroenke dkroenke deleted the iox-#27-add-client-and-server-examples branch February 28, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budrus budrus budrus approved these changes

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler FerdinandSpitzschnueffler approved these changes

@dkroenke dkroenke Awaiting requested review from dkroenke

@elfenpiff elfenpiff Awaiting requested review from elfenpiff

Assignees

@elBoberido elBoberido

Labels
example providing example for a specific feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request/Response communication with iceoryx
5 participants
@elBoberido @FerdinandSpitzschnueffler @dkroenke @budrus @elfenpiff