-
Notifications
You must be signed in to change notification settings - Fork 421
iox-#27 Add ServerPort #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elBoberido
merged 26 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#27-server-port-implementation-and-test
Feb 10, 2022
Merged
iox-#27 Add ServerPort #1033
elBoberido
merged 26 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#27-server-port-implementation-and-test
Feb 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3404bd0
to
a2c5a66
Compare
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
+ Coverage 76.09% 76.80% +0.71%
==========================================
Files 344 345 +1
Lines 13024 13158 +134
Branches 1865 1885 +20
==========================================
+ Hits 9910 10106 +196
+ Misses 2498 2435 -63
- Partials 616 617 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elfenpiff
reviewed
Jan 24, 2022
iceoryx_posh/include/iceoryx_posh/internal/popo/ports/server_port_roudi.hpp
Outdated
Show resolved
Hide resolved
105d7ce
to
c05234f
Compare
14bfa32
to
924394b
Compare
elBoberido
commented
Feb 4, 2022
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_receiver.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_receiver.inl
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.inl
Outdated
Show resolved
Hide resolved
22 tasks
af9118e
to
d69e768
Compare
…lt to ServerRequestResult
f6c937f
to
f15da03
Compare
143e328
to
40020a2
Compare
40020a2
to
3baab9a
Compare
elfenpiff
approved these changes
Feb 10, 2022
MatthiasKillat
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
The changelog will only be updated once the feature is ready.
This MR implements the Server part for the Request/Response communication and add the unit tests.
I'm not that happy with the raw pointer in the API but it is modeled after the
PublisherPort
/SubscriberPort
. Ideally, only references would be used, but I'm not sure if this should be done in this PR or if all the ports should be adjusted. Currently this is only internal API so we could change this later without our users suffering on breaking API calls.Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References