Skip to content

iox-#27 Add ServerPort #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 21, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

The changelog will only be updated once the feature is ready.

This MR implements the Server part for the Request/Response communication and add the unit tests.

I'm not that happy with the raw pointer in the API but it is modeled after the PublisherPort/SubscriberPort. Ideally, only references would be used, but I'm not sure if this should be done in this PR or if all the ports should be adjusted. Currently this is only internal API so we could change this later without our users suffering on breaking API calls.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the enhancement New feature label Jan 21, 2022
@elBoberido elBoberido self-assigned this Jan 21, 2022
@elBoberido elBoberido force-pushed the iox-#27-server-port-implementation-and-test branch from 3404bd0 to a2c5a66 Compare January 21, 2022 12:12
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1033 (e87b105) into master (800957f) will increase coverage by 0.71%.
The diff coverage is 93.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   76.09%   76.80%   +0.71%     
==========================================
  Files         344      345       +1     
  Lines       13024    13158     +134     
  Branches     1865     1885      +20     
==========================================
+ Hits         9910    10106     +196     
+ Misses       2498     2435      -63     
- Partials      616      617       +1     
Flag Coverage Δ
unittests 76.02% <93.29%> (+0.70%) ⬆️
unittests_timing 12.41% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osh/internal/popo/building_blocks/chunk_sender.hpp 100.00% <ø> (ø)
...ryx_posh/internal/popo/ports/client_port_roudi.hpp 100.00% <ø> (ø)
...ryx_posh/internal/popo/ports/server_port_roudi.hpp 100.00% <ø> (+100.00%) ⬆️
...oryx_posh/internal/popo/ports/server_port_user.hpp 100.00% <ø> (+100.00%) ⬆️
...oryx_posh/internal/popo/ports/server_port_user.inl 70.83% <70.83%> (ø)
...eoryx_posh/source/popo/ports/client_port_roudi.cpp 94.95% <92.85%> (ø)
...eoryx_posh/source/popo/ports/server_port_roudi.cpp 95.89% <95.08%> (+95.89%) ⬆️
...ceoryx_binding_c/source/cpp2c_enum_translation.cpp 100.00% <100.00%> (ø)
...osh/internal/popo/building_blocks/chunk_sender.inl 87.61% <100.00%> (+0.24%) ⬆️
...ceoryx_posh/source/popo/ports/client_port_user.cpp 96.77% <100.00%> (+0.05%) ⬆️
... and 11 more

@elBoberido elBoberido force-pushed the iox-#27-server-port-implementation-and-test branch 2 times, most recently from 105d7ce to c05234f Compare January 27, 2022 17:58
@elBoberido elBoberido force-pushed the iox-#27-server-port-implementation-and-test branch 10 times, most recently from 14bfa32 to 924394b Compare February 4, 2022 00:41
@elBoberido elBoberido changed the title [do-not-review] iox-#27 Add ServerPort iox-#27 Add ServerPort Feb 4, 2022
@elBoberido elBoberido marked this pull request as ready for review February 4, 2022 00:48
@elBoberido elBoberido linked an issue Feb 4, 2022 that may be closed by this pull request
22 tasks
@elBoberido elBoberido force-pushed the iox-#27-server-port-implementation-and-test branch 7 times, most recently from af9118e to d69e768 Compare February 4, 2022 18:04
@elBoberido elBoberido force-pushed the iox-#27-server-port-implementation-and-test branch from f6c937f to f15da03 Compare February 10, 2022 13:34
@dkroenke dkroenke force-pushed the iox-#27-server-port-implementation-and-test branch 5 times, most recently from 143e328 to 40020a2 Compare February 10, 2022 14:24
@dkroenke dkroenke force-pushed the iox-#27-server-port-implementation-and-test branch from 40020a2 to 3baab9a Compare February 10, 2022 14:25
@elBoberido elBoberido merged commit a6085ff into eclipse-iceoryx:master Feb 10, 2022
@elBoberido elBoberido deleted the iox-#27-server-port-implementation-and-test branch February 10, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request/Response communication with iceoryx
5 participants