Skip to content

Remove #define private public from all tests #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
dkroenke opened this issue Jan 29, 2021 · 5 comments · Fixed by #882 or #883
Closed
6 tasks done

Remove #define private public from all tests #529

dkroenke opened this issue Jan 29, 2021 · 5 comments · Fixed by #882 or #883
Labels
good first issue Good for newcomers
Milestone

Comments

@dkroenke
Copy link
Member

dkroenke commented Jan 29, 2021

Required information

In some of the iceoryx tests are defines used for making private=public which is against our principle of white-box testing.
Additionally this doesn't compile on windows.

Task

  • remove #define private public and #define protected public from all testfiles
    • test_gw_gateway_discovery.cpp (part of #Iox #190 fixed point types for duration internal representation #501)
    • test_roudi_service_registry.cpp (trivial)
    • test_objectpool.cpp (easy by making protected accessor methods; the objectpool might be removed in the future though)
    • test_mq_interface.cpp (intermediate; mq_interface will be refactored in the near future though)
    • test_posh_mepoo.cpp (non-trivial and probably difficult)
@dkroenke dkroenke added the good first issue Good for newcomers label Jan 29, 2021
@dkroenke dkroenke added this to the Prio 3 milestone Jan 29, 2021
@dkroenke dkroenke changed the title Remove #define private public from all tests Remove #define private public from all tests Jan 29, 2021
@elBoberido
Copy link
Member

oh, I also added it to the Windows Issue.
Nevertheless, test_gw_gateway_discovery.cpp will be fixed with the Duration PR

@elBoberido elBoberido mentioned this issue Jan 29, 2021
7 tasks
@dkroenke
Copy link
Member Author

@elBoberido yes right, this is for the new contributors to get familiar.

@elBoberido
Copy link
Member

@dkroenke I had a look at it yesterday and at least one is not quite trivial to solve. Shall I tag the files from easy to difficult?

@dkroenke
Copy link
Member Author

@elBoberido Yes that definitely make sense

@elBoberido
Copy link
Member

@dkroenke done. I think mq_interface will be refactored in the near future and should maybe be done with that refactoring

elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2021
…di_service_registry.cpp

Signed-off-by: Mathias Kraus <[email protected]>
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 13, 2021
…di_service_registry.cpp

Signed-off-by: Mathias Kraus <[email protected]>
@dkroenke dkroenke linked a pull request Jul 29, 2021 that will close this issue
20 tasks
dkroenke added a commit that referenced this issue Jul 29, 2021
…bjectpool

iox-#529 Remove define private public from test_objectpool
@mossmaurice mossmaurice reopened this Jul 29, 2021
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 30, 2021
* Use real subscriber to get introspection data (slows down a test
  unfortunately) instead of internal class members
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 30, 2021
* Use real subscriber to get introspection data (slows down a test
  unfortunately) instead of internal class members
@elBoberido elBoberido linked a pull request Jul 30, 2021 that will close this issue
20 tasks
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Jul 31, 2021
* Use real subscriber to get introspection data (slows down a test
  unfortunately) instead of internal class members
r7vme pushed a commit to ApexAI/iceoryx that referenced this issue Aug 2, 2021
* Use real subscriber to get introspection data (slows down a test
  unfortunately) instead of internal class members
mossmaurice pushed a commit that referenced this issue Aug 2, 2021
…mepoo

iox-#529 Remove define private from mepoo test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants