Skip to content

[EGL] Fix some parse problems reporting incorrect position #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Arkaedan
Copy link
Contributor

Fixes #166

The issue was caused by the EglParseProblem assuming that the preprocessing had been done however some parse problems can happen before preprocessing and in those cases preprocessing does not run.

@Arkaedan Arkaedan force-pushed the fix-egl-wrong-parse-problem-line branch from 8507b6f to 6686051 Compare May 14, 2025 10:13
@kolovos
Copy link
Contributor

kolovos commented May 14, 2025

Many thanks for investigating! I'm wondering whether this can be further simplified by undoing the changes to Preprocessor and changing

if (!preprocessor.hasRun()) {
	return parseProblems;
}

to

if (!eglParser.getParseProblems().isEmpty()) {
	return parseProblems;
}

in EglModule?

@Arkaedan Arkaedan force-pushed the fix-egl-wrong-parse-problem-line branch from 6686051 to 7e6d696 Compare May 14, 2025 15:06
@Arkaedan
Copy link
Contributor Author

Many thanks for investigating! I'm wondering whether this can be further simplified by undoing the changes to Preprocessor and changing

if (!preprocessor.hasRun()) {
	return parseProblems;
}

to

if (!eglParser.getParseProblems().isEmpty()) {
	return parseProblems;
}

in EglModule?

Yep you're right. Thanks!

@kolovos kolovos merged commit e8acfde into eclipse-epsilon:main May 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EGL parse errors reported on the wrong line
2 participants