Removed deprecated usages of getPeerCertificateChain #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o SSLSupport - to maintain the backward compatibility I added two new methods consistent with SSLSession API and old were marked as deprecated. - note that if someone extendeds the interface, he still has to add those new methods OR better: rename and update his implementation. No changes should be required to just call grizzly's implementation. Signed-off-by: David Matějček <[email protected]>
arjantijms
approved these changes
Dec 10, 2021
Let's leave them in for 1 version, so people who find those methods have disappeared can look at the previous version to see what they moved to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A message for the kind reviewer: if you think that it would be good to simply remove those methods now marked as deprecated, I can do that. The
SSLSession.getPeerCertificateChainused by the old implementation is not existing in JDK17 any more.In regard to backward compatibility - calling deprecated methods should be still possible, but implementing the interface means implementing the new version.
Locally all tests passed on JDK11 and JDK17.