Skip to content

Grizzly is not compatible with Servlet 6 #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jansupol opened this issue Feb 21, 2022 · 10 comments
Closed

Grizzly is not compatible with Servlet 6 #2153

jansupol opened this issue Feb 21, 2022 · 10 comments

Comments

@jansupol
Copy link

jakarta.servlet.SingleThreadModel is no longer in Servlet 6 API.

For instance, WebappContext is not compatible with Servlet 6.

@arjantijms
Copy link
Contributor

Thanks for the reminder, that indeed still needs to be done.

That aside, I wonder btw if the half-finished Servlet implementation in Grizzly is really needed still. Is anyone really using this?

@jansupol
Copy link
Author

Jersey is using it for the test framework. I think the Jersey test framework is also used by one of the spring boot modules.

@arjantijms
Copy link
Contributor

Interesting. Did you ever try running the Servlet TCK against Grizzly to get an idea what percentage of the Servlet API is implemented?

And just curiously, but was it really the idea to turn Grizzly into a fully compliant Servlet implementation?

@jansupol
Copy link
Author

As far as I remember, Alexey implemented just the minimum functionality for mocking the servlet deployment. It was never meant to be a full servlet implementation.

@lukasj
Copy link
Member

lukasj commented Mar 10, 2022

metro needs grizzly as well in order to be fully buildable from sources, see eclipse-ee4j/metro-wsit#155

@smillidge
Copy link
Contributor

So is this issue just requesting a build with the Servlet API brought up to speed with Servlet 6 i.e. not an implementation but something you can compile against?

@lukasj
Copy link
Member

lukasj commented Mar 11, 2022

from metro point of view - yes; should there be need for anything specific to be implemented, that can be done once we see real failure (ie metro uses grizzly for tcp level transport)

@jansupol
Copy link
Author

This issue is about replacing the Servlet 5 deprecated methods that have been removed in Servlet 6 with methods that are not deprecated.

@dmatej
Copy link
Contributor

dmatej commented Mar 15, 2022

Just FYI, I am working on that, I hope I will be able to push (first?) changes today.

dmatej added a commit to dmatej/grizzly that referenced this issue Mar 16, 2022
arjantijms added a commit that referenced this issue Mar 16, 2022
#2153 Started development of Grizzly 4
dmatej added a commit to dmatej/grizzly that referenced this issue Mar 16, 2022
dmatej added a commit to dmatej/grizzly that referenced this issue Mar 16, 2022
arjantijms added a commit that referenced this issue Mar 16, 2022
Implemented #2153 - Upgraded to Servlet 6
@dmatej
Copy link
Contributor

dmatej commented Mar 18, 2022

This issue can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants