Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Adapt Che Theia to upstream Theia changes: SemanticTokens Plug-in API #908

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Nov 4, 2020

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

Adapts Che Theia to upstream Theia changes: SemanticTokens Plug-in API.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

closes eclipse-che/che#18263

How to test this PR?

The build and HappyPath test are green against upstream Theia.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:908
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:908

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:908
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:908

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:908
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:908

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:908
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:908

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:908
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:908

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy azatsarynnyy marked this pull request as ready for review November 4, 2020 20:23
@azatsarynnyy azatsarynnyy merged commit 757ca20 into master Nov 4, 2020
@azatsarynnyy azatsarynnyy deleted the adapt-2-upstream branch November 4, 2020 20:28
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 4, 2020
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 5, 2020
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt Che Theia to upstream Theia changes
3 participants