This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Update Go dependencies. #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggering reason is to fix a vulnerability in gRPC <1.53
lukasmittag
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
What I did:
- tested if it runs
I see that there are many changes in .sum. I think it is okay. It could be avoided bygo get -u google.golang.org/grpc. That would only update grpc dependencies. But I thinks since it does not break anything it is okay to update everything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering reason is to fix a vulnerability in gRPC <1.53
I am by no means a go expert and I do not really know why the
go.sumfile becomes so much larger than before. but I have documented in the README how I updated the versions, and I have tested against both Databroker and Server that things seems to work like before.