Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Feature/update fix Testclient and Python Package to spport GRPC #304

Conversation

SebastianSchildt
Copy link
Contributor

With the GRPC changes in #299, the client could only be executed locally. Python package and Docker where broken. This should fix it. Expectation ist

  • testclient still works in (a pipenv) in a local source checkout
  • Python package can be build
    • build with python setup.py bdist_wheel
  • Docker container for testclient works
    • Build with docker build -t testclient -f kuksa_viss_client/Dockerfile . or wait for GH action and pull from ttl.sh before the image expires

Also, the python packaged related config files (setuptools stuff) have been moved into the kuksa_viss_client folder

@SebastianSchildt SebastianSchildt changed the title Feature/update fix Testclient and Python Package tu spport GRPC Feature/update fix Testclient and Python Package to spport GRPC Jul 22, 2022
Copy link
Contributor

@nayakned nayakned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the three variants and found it to be working.

  • Local
  • Docker
  • Built package inside a docker container and installed it.

Can be merged.

@SebastianSchildt SebastianSchildt merged commit 6d332ed into eclipse-archived:master Jul 25, 2022
@SebastianSchildt SebastianSchildt deleted the feature/update_fix__pyclient_package branch July 25, 2022 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants