Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Add databroker #279

Merged

Conversation

argerus
Copy link
Contributor

@argerus argerus commented May 25, 2022

Signed-off-by: John Argérus [email protected]

@argerus argerus closed this May 25, 2022
@argerus argerus reopened this May 25, 2022
@argerus argerus force-pushed the topic/add_databroker branch 3 times, most recently from 2cf2447 to 236a425 Compare May 25, 2022 16:46
@argerus argerus force-pushed the topic/add_databroker branch from 236a425 to e9596da Compare June 3, 2022 12:23
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @argerus , can you also modify the main project Readme table with a small row referencing data broker?

For example, something like this

License Component Description
License kuksa-databroker Efficient in-vehicle signal broker written in RUST

We probably need to get more wordy there in the near future, but for now let's at least have a complete TOC 😄

@argerus argerus force-pushed the topic/add_databroker branch from e9596da to fefb771 Compare June 3, 2022 20:17
@argerus
Copy link
Contributor Author

argerus commented Jun 3, 2022

Hi @argerus , can you also modify the main project Readme table

done

@argerus argerus requested a review from SebastianSchildt June 5, 2022 15:17
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just two minor comments/questions ^^

Signed-off-by: John Argérus <[email protected]>
@argerus argerus force-pushed the topic/add_databroker branch from fefb771 to b1b8345 Compare June 7, 2022 08:22
@argerus argerus requested a review from SebastianSchildt June 7, 2022 09:08
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianSchildt SebastianSchildt merged commit 3b6c369 into eclipse-archived:master Jun 7, 2022
@SebastianSchildt SebastianSchildt deleted the topic/add_databroker branch August 26, 2022 14:45
erikbosch pushed a commit to erikbosch/kuksa.val that referenced this pull request Oct 20, 2023
erikbosch pushed a commit to boschglobal/kuksa.val that referenced this pull request Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants