Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Subscriptions Fixes 1 #264

Merged

Conversation

SebastianSchildt
Copy link
Contributor

@SebastianSchildt SebastianSchildt commented Apr 11, 2022

Fixes nothing in #263 , but makes subscriptions a little more robust

  • enforcing string type subscriptionIDs both directions
    • fixes the occasional "Integer Overflow" on unsubscribe
  • JSON schema checking for subscribe and unsubscribe requests
  • as a result, overall more helpful error messages

@nayakned please check if it, at the very least, does not make things worse :)

@nayakned
Copy link
Contributor

Looks good. These changes fix a part of #261.
Maybe also fix the error code returned in JSON object or document that it will be an int.
Then we can also close #261.

@SebastianSchildt
Copy link
Contributor Author

Now all error codes are returned as string. This will fix #261 , please check @nayakned

@nayakned
Copy link
Contributor

Checked a couple of errors. Those were strings as expected.

@SebastianSchildt SebastianSchildt merged commit a05caf8 into eclipse-archived:master Apr 13, 2022
@SebastianSchildt SebastianSchildt deleted the fix/subscriptions1 branch April 20, 2022 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants