This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Fix dbcfeeder #239
Merged
Fix dbcfeeder #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianSchildt
suggested changes
Oct 15, 2021
There was a problem hiding this comment.
Hi, vehicle.speed is float, see COVESA/vehicle_signal_specification#234, a similar PR exists for the OBD variant. If the shipped vss is too old, we should rather make a seperate PR adding newer VSS releases…
the change to set str() is good
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbcfeeder sends float to
Vehicle.Speedin the past, butVehicle.Speedisint32related to #209