Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

141 test client version number #143

Conversation

wenwenchenbosch
Copy link
Contributor

@wenwenchenbosch wenwenchenbosch commented Mar 29, 2021

solve #143

@wenwenchenbosch wenwenchenbosch force-pushed the 141_test_client_version_number branch from 84b9cc4 to 136554d Compare March 29, 2021 17:31
Signed-off-by: Chen Wenwen (CR/AME5) <[email protected]>
Signed-off-by: Chen Wenwen (CR/AME5) <[email protected]>
@SebastianSchildt
Copy link
Contributor

I would suggest removing the logo, as it is very large, an probably a little annyoing if you see it every time starting the testclient, especially since it sort of defeats the purpose of seeing the verison number,as it easily scrolls out of view
grafik

(or it can somehwo be made MUCH smaller, (i.e. no "KUKSA" text and version beside the "graphic")

Signed-off-by: Chen Wenwen (CR/AME5) <[email protected]>
Signed-off-by: Chen Wenwen (CR/AME5) <[email protected]>
@wenwenchenbosch
Copy link
Contributor Author

@SebastianSchildt now the logo should be smaller.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a fan of the logo, but want the feature anyway 🍰

@SebastianSchildt SebastianSchildt merged commit 061fe1d into eclipse-archived:master Mar 30, 2021
@wenwenchenbosch wenwenchenbosch deleted the 141_test_client_version_number branch May 6, 2021 10:13
@wenwenchenbosch
Copy link
Contributor Author

@SebastianSchildt also no merge commit? no merge commit very fatal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants