Skip to content

feat(framework): chakra ui #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

feat(framework): chakra ui #37

merged 1 commit into from
Sep 30, 2021

Conversation

Jonathangarrido
Copy link
Collaborator

@Jonathangarrido Jonathangarrido commented Sep 24, 2021

Descripción

Agregar chakra-UI como framework base, agregando configuración que se definió en la guía de estilos de diseño.

Me faltaron ciertos puntos: Me pueden ayudar con esto @alv-alvarez @josefin-ferrada por favor

  • Toda la configuración del theme que creamos vaya con su types correspondientes
  • Stories de Storybook deben llevar el provider de chakra

Tipos de cambios

  • Bugfix (cambio ininterrumpido que soluciona un problema)
  • Feature (cambio sin interrupciones que agrega funcionalidad)
  • Breaking change (corrección o característica que haría que la funcionalidad existente no funcionara como se esperaba)

@alv-alvarez alv-alvarez force-pushed the feature/chakra branch 3 times, most recently from bdce5c5 to d2131ff Compare September 28, 2021 14:56
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 28, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb133e6
Status: ✅  Deploy successful!
Preview URL: https://3464eee9.ui-kit-316.pages.dev

View logs

@alv-alvarez alv-alvarez force-pushed the feature/chakra branch 2 times, most recently from 81c9e1a to 6e71fb8 Compare September 30, 2021 13:59
@alv-alvarez
Copy link
Contributor

La tarea de crear los types para el custom theme queda pendiente en el issue #57

@alv-alvarez alv-alvarez marked this pull request as ready for review September 30, 2021 14:14
@alv-alvarez alv-alvarez merged commit ffcd24f into main Sep 30, 2021
@alv-alvarez alv-alvarez deleted the feature/chakra branch September 30, 2021 14:14
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants