i.smap: Test with cmake llvm sanitizers

.github/workflows/cmake.yml

@@ -27,6 +27,13 @@ jobs:
     runs-on: ubuntu-22.04
     env:
       CMakeVersion: "3.22.0"
+      CC: clang-${{ matrix.llvm-version }}
+      CXX: clang++-${{ matrix.llvm-version }}
+      ASAN_OPTIONS: detect_leaks=0
+
+    strategy:
+      matrix:
+        llvm-version: [19]
     steps:
       - name: Checkout GRASS
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -41,10 +48,19 @@ jobs:
           echo "$GITHUB_WORKSPACE/cmake-${{ env.CMakeVersion }}-${arch}/bin" >> $GITHUB_PATH
       - run: |
           cmake --version
+      - name: Apt LLVM
+        run: |
+          wget https://apt.llvm.org/llvm.sh
+          chmod +x llvm.sh
+          sudo ./llvm.sh ${{ matrix.llvm-version }}
+          sudo apt-get update
       - name: Install dependencies
         run: |
           sudo apt-get update -y
           sudo apt-get install -y wget git gawk findutils ninja-build libpq-dev \
+            clang-${{ matrix.llvm-version }} clang-tools-${{ matrix.llvm-version }} \
+            libomp-${{ matrix.llvm-version }}-dev lld-${{ matrix.llvm-version }} \
+            llvm-${{ matrix.llvm-version }} \
             gettext unixodbc-dev libnetcdf-dev
           xargs -a <(awk '! /^ *(#|$)/' ".github/workflows/apt.txt") -r -- \
               sudo apt-get install -y --no-install-recommends --no-install-suggests
@@ -61,7 +77,9 @@ jobs:
         run: |
           cmake ${CMAKE_OPTIONS} -S $GITHUB_WORKSPACE -B $GITHUB_WORKSPACE/build -G Ninja \
             -DCMAKE_INSTALL_PREFIX=$HOME/install -DWITH_NLS=ON -DWITH_GUI=OFF -DWITH_DOCS=OFF \
-            -DWITH_READLINE=ON -DWITH_ODBC=ON -DWITH_NETCDF=ON -DWITH_BZLIB=ON
+            -DWITH_READLINE=ON -DWITH_ODBC=ON -DWITH_NETCDF=ON -DWITH_BZLIB=ON \
+            -DBUILD_SHARED_LIBS=OFF \
+            -DCMAKE_C_COMPILER=clang-${{ matrix.llvm-version }} -DCMAKE_CXX_COMPILER=clang++-${{ matrix.llvm-version }}
       - name: Print CMakeCache.txt
         shell: bash -el {0}
         run: |
@@ -75,6 +93,8 @@ jobs:
       - name: Add the bin directory to PATH
         run: |
           echo "$HOME/install/bin" >> $GITHUB_PATH
+      - name: Set profile file name env var
+        run: echo "LLVM_PROFILE_FILE=${{ github.workspace }}/grass-prof-%p-%4m.profraw" >> $GITHUB_ENV
       - name: Print installed versions
         if: always()
         run: .github/workflows/print_versions.sh
@@ -89,3 +109,46 @@ jobs:
           name: testreport-CMake
           path: testreport
           retention-days: 3
+      - name: Use llvm's coverage script
+        if: ${{ !cancelled() }}
+        run: |
+          WORKSPACE=$GITHUB_WORKSPACE
+
+          BUILD_DIR=$(pwd)/dist*
+          FAST_BUILD_DIR=$(pwd)/clang-build
+          REPORT_DIR=$(pwd)/coverage-reports
+          HOST=
+          LLVM_PROFDATA=llvm-profdata-${{ matrix.llvm-version }}
+          LLVM_COV=llvm-cov-${{ matrix.llvm-version }}
+          ARTIFACT_PREP_SCRIPT=$WORKSPACE/utils/prepare-code-coverage-artifact.py
+
+          PROFILES_DIR=$WORKSPACE
+
+          COV_BINARIES=$(find ./build/output/ -type f \( -executable -o -name "*.dylib" -o -name "*.so*" \) \
+            -exec file {} + | grep -E 'Mach-O|ELF' | cut -d':' -f1)
+
+          rm -rf $REPORT_DIR
+          mkdir -p $REPORT_DIR
+          python $ARTIFACT_PREP_SCRIPT $LLVM_PROFDATA $LLVM_COV \
+            $PROFILES_DIR $REPORT_DIR $COV_BINARIES \
+            --unified-report \
+            --lcov=grass.llvm-source.coverage.lcov
+      - name: Make profile data available
+        if: ${{ !cancelled() }}
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: >-
+            profile-data-${{ 'cmake' }}
+          path: |
+            *.prof*
+            *coverage*
+            llvm_coverage*/**
+          retention-days: 1
+      - name: Upload coverage reports to Codecov
+        if: ${{ !cancelled() }}
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+        with:
+          verbose: true
+          flags: linux-cmake
+          name: linux-cmake
+          token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/macos.yml

@@ -55,6 +55,7 @@ jobs:
       - name: Prepare Conda environment file
         env:
           test_dependencies: |
+            findutils
             ipython
             pytest
             pytest-github-actions-annotate-failures
@@ -73,6 +74,8 @@ jobs:
           # Persist on the same period (date).
           cache-environment-key: environment-${{ steps.date.outputs.date }}
 
+      - name: Set profile file name env var
+        run: echo "LLVM_PROFILE_FILE=${{ github.workspace }}/grass-prof-%p-%4m.profraw" >> $GITHUB_ENV
       - name: Environment info
         shell: bash -el {0}
         run: |
@@ -89,6 +92,9 @@ jobs:
         if: ${{ !cancelled() }}
         shell: micromamba-shell {0}
         run: source ./.github/workflows/print_versions.sh
+      - name: Print config
+        shell: micromamba-shell {0}
+        run: grass --config
 
       - name: Run pytest with multiple workers in parallel
         shell: micromamba-shell {0}
@@ -147,3 +153,61 @@ jobs:
           name: testreport-macOS
           path: testreport
           retention-days: 3
+      # - name: Merge and index profile data
+      #   shell: micromamba-shell {0}
+      #   run: |
+      #     llvm-profdata merge -sparse *.profraw -o merged.profdata
+      #     rm *.profraw
+      # - name: Export coverage report with llvm-cov export (all, json)
+      #   shell: micromamba-shell {0}
+      #   continue-on-error: true
+      #   run: |
+      #     COV_BINARIES=$(find . -type f \( -executable -o -name "*.dylib" \) \
+      #       -exec file {} + | grep -E 'Mach-O|ELF' | cut -d':' -f1)
+      #     llvm-cov export -format=text -instr-profile=merged.profdata \
+      #       /Users/runner/install/grass85/lib/libgrass_gis.8.5.dylib  \
+      #       | tee coverage.all1.json
+      - name: Use llvm's coverage script
+        if: ${{ !cancelled() }}
+        shell: micromamba-shell {0}
+        run: |
+          WORKSPACE=$GITHUB_WORKSPACE
+
+          BUILD_DIR=$(pwd)/dist*
+          FAST_BUILD_DIR=$(pwd)/clang-build
+          REPORT_DIR=$(pwd)/coverage-reports
+          HOST=
+          LLVM_PROFDATA=llvm-profdata
+          LLVM_COV=llvm-cov
+          ARTIFACT_PREP_SCRIPT=$WORKSPACE/utils/prepare-code-coverage-artifact.py
+
+          PROFILES_DIR=$WORKSPACE
+
+          COV_BINARIES=$(find . -type f \( -executable -o -name "*.dylib" \) \
+            -exec file {} + | grep -E 'Mach-O|ELF' | cut -d':' -f1)
+
+          rm -rf $REPORT_DIR
+          mkdir -p $REPORT_DIR
+          python $ARTIFACT_PREP_SCRIPT $LLVM_PROFDATA $LLVM_COV \
+            $PROFILES_DIR $REPORT_DIR $COV_BINARIES \
+            --unified-report \
+            --lcov=grass.llvm-source.coverage.lcov
+      - name: Make profile data available
+        if: ${{ !cancelled() }}
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: >-
+            profile-data-${{ 'macos-14' }}
+          path: |
+            *.prof*
+            *coverage*
+            llvm_coverage*/**
+          retention-days: 1
+      - name: Upload coverage reports to Codecov
+        if: ${{ !cancelled() }}
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
+        with:
+          verbose: true
+          flags: pytest-macos-14
+          name: pytest-macos-14
+          token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/macos_install.sh

@@ -59,14 +59,20 @@ CONFIGURE_FLAGS="\
   --without-x \
 "
 
+export EXTRA_COV_FLAGS="-fprofile-instr-generate -fcoverage-mapping"
 export CFLAGS="-O2 -pipe -ffp-contract=off -arch ${CONDA_ARCH} -DGL_SILENCE_DEPRECATION -Wall -Wextra -Wpedantic -Wvla"
 export CXXFLAGS="-O2 -pipe -ffp-contract=off -stdlib=libc++ -arch ${CONDA_ARCH} -Wall -Wextra -Wpedantic"
 export CPPFLAGS="-isystem${CONDA_PREFIX}/include"
 
-./configure $CONFIGURE_FLAGS
+export CFLAGS="$EXTRA_COV_FLAGS $CFLAGS"
+export CXXFLAGS="$EXTRA_COV_FLAGS $CXXFLAGS"
+
+LDFLAGS="-fprofile-instr-generate $LDFLAGS" ./configure $CONFIGURE_FLAGS
 
 EXEMPT=""
-make -j$(sysctl -n hw.ncpu) CFLAGS="$CFLAGS -Werror $EXEMPT" \
+# make -j$(sysctl -n hw.ncpu) CFLAGS="$CFLAGS -Werror $EXEMPT" \
+#   CXXFLAGS="$CXXFLAGS -Werror $EXEMPT"
+make -j1 CFLAGS="$CFLAGS -Werror $EXEMPT" \
   CXXFLAGS="$CXXFLAGS -Werror $EXEMPT"
 
 make install

.gunittest.cfg

@@ -25,6 +25,9 @@ exclude =
     vector/v.in.pdal/testsuite/test_v_in_pdal_basic.py
     vector/v.in.pdal/testsuite/test_v_in_pdal_filter.py
     vector/v.out.lidar/testsuite/test_v_out_lidar.py
+    temporal/.*
+    *.sh
+    raster/r.s*
 
 # Maximum time for execution of one test file (not a test function)
 # after which test is terminated (which may not terminate child processes

CMakeLists.txt

@@ -45,6 +45,9 @@ if(NOT CMAKE_C_STANDARD)
   set(CMAKE_C_STANDARD 11)
   set(CMAKE_C_STANDARD_REQUIRED ON)
 endif()
+SET(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -g -fprofile-instr-generate -fcoverage-mapping -fno-omit-frame-pointer -fsanitize=address")
+SET(CMAKE_C_FLAGS  "${CMAKE_C_FLAGS} -g -fprofile-instr-generate -fcoverage-mapping -fno-omit-frame-pointer -fsanitize=address")
+SET(CMAKE_EXE_LINKER_FLAGS  "${CMAKE_EXE_LINKER_FLAGS} -fprofile-instr-generate -fno-omit-frame-pointer -fsanitize=address")
 
 set(x11_default_option_enabled ON)
 set(nls_default_option_enabled ON)

imagery/i.smap/model.c

@@ -141,7 +141,7 @@ void extract(DCELL ***img,          /* multispectral image, img[band][i][j] */
                         ll[i][j][m] = subll[0];
                     }
                     /* compute mixture likelihood */
-                    else {
+                    else if (C->nsubclasses > 1) {
                         /* find the most likely subclass */
                         for (k = 0; k < C->nsubclasses; k++) {
                             if (k == 0)
@@ -157,6 +157,9 @@ void extract(DCELL ***img,          /* multispectral image, img[band][i][j] */
 
                         ll[i][j][m] = log(subsum) + maxlike;
                     }
+                    else {
+                        ll[i][j][m] = 0.0;
+                    }
                 }
             }
         }