Nt/replacing iphone x package #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
apparently iphone x helper package was causing a lot ui related spacing issues, considering it was even last updated four years ago, it is only sensible to replace it with updated safe-area-context methods.
An extra change for No Connection popup is, I had to position it at the bottom, refining ui while keep it up top was becoming tricky, it's possible but it seems too much effort considering it's application is very minor. let me know it important to keep it up top.
Issue number
https://github.com/orgs/ecency/projects/4/views/1?pane=issue&itemId=106720803
https://github.com/orgs/ecency/projects/4/views/1?pane=issue&itemId=97602273
Screenshots/Video