Skip to content

Nt/poll tweaks #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 22, 2025
Merged

Nt/poll tweaks #2955

merged 22 commits into from
May 22, 2025

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Jan 23, 2025 •
edited
Loading

What does this PR?

  • updated schema while creating poll and fetching polls
  • support for rendering community restrictions
  • support for rendering show stats based on selected token
  • support for show/hide results before voting, though author can view results irrespective of vote status
  • change basic token based interpretation to HIVE:HP

NOTE: we do not yet support adding community restrictions and custom token while creating poll in poll wizard, it is only supported while rendering polls if other client add such restrictions/options.

Issue number

https://github.com/orgs/ecency/projects/4/views/1?filterQuery=poll&pane=issue&itemId=111726818

Screenshots/Video

Screenshot 2025-05-22 at 17 20 46
Screenshot 2025-05-22 at 17 21 19
Screenshot 2025-05-22 at 17 21 54
Screenshot 2025-05-22 at 17 22 18

@noumantahir
updated poll model
e399b97
@noumantahir
updated poll model
19d473b
@noumantahir
add todo tags to support official vote change option
07d2eac
@noumantahir
updated poll model
543202f
@noumantahir
Merge branch 'development' into nt/poll-tweaks
caaa303
@noumantahir
showing selected token in poll header
f4c1492
@noumantahir
put back ecency poll prop hive_votes
419f118
@noumantahir
updated poll draft model
4a26776
@noumantahir
updated poll model converter
a911c82
@noumantahir
poll draft to poll metadata support new props
f15e09e
@noumantahir
updated default poll metadata initialisation
3ad7d92
@noumantahir
added hive results option in poll config
b176c02
@noumantahir
using hide results option in poll rendering
ababb8e
@noumantahir
changed vote_change to allow_votes_changes props as now supported by …
876826f 
…poll backend
@noumantahir
showing community membersip restriction for poll
6f0230d
@noumantahir
setting default token if token interpretation is selected
7141554
@noumantahir
added missing translated texts for poll
9693d84
@noumantahir
storing polls protocol version in polls api provider
ef9218d
@noumantahir
using various token options to calculate votes percentage
0037067
@noumantahir
Merge remote-tracking branch 'origin/development' into nt/poll-tweaks
9d31d8f
@noumantahir noumantahir requested a review from feruzm May 22, 2025 12:28
@noumantahir noumantahir marked this pull request as ready for review May 22, 2025 12:29
feruzm
feruzm approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 0ed5ed7 into development May 22, 2025
@feruzm feruzm deleted the nt/poll-tweaks branch May 22, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm