forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Teads Bid Adapter: add new features to request payload #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
teads-antoine-azar
wants to merge
921
commits into
master
Choose a base branch
from
add_features_to_teads_adapter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release adapter Copper6SSP * removed code duplication * add gvl_id
…g fix (prebid#12511) * update intentIqAnalyticsAdapter.js && intentIqIdSystem.js * fix lint issues * fix tests * move info * resolve issues * update storeFirstPartyData * remove unused code * update defineEmptyDataAndFireCallback * update fix lint * update reportExternalWin * small fixes * update test && add docs * AGT-347: Support domain name * AGT-347: Support domain name * AGT-374: Support domainName to vrref * AGT-374: tests in progress * AGT-374: Remove duplicate encoded in getRelevantRefferer and fix tests * AGT-374: Add test domainName, changes in documentation * AGT-374: Change js version value * AGT-374: Remove extra coma * Remove unused method * AGT-384: gpp string value * AGT-384: GPC value, browserDetector fix * AGT-384: Remove gpc logic * AGT-384: Reduce getGppValue method * AGT-384: Gpp tests and prevent send ids from LS in group B * AGT-384: Change empty array of eids * AGT-384: Some fixes after review --------- Co-authored-by: dlepetynskyi <[email protected]> Co-authored-by: DimaIntentIQ <[email protected]> Co-authored-by: DimaIntentIQ <[email protected]>
…ge configuration object (prebid#12403)
Co-authored-by: dev <[email protected]>
* Push context data to GAM * Update browsi to set gpt key values * fix browsi * Revamps module to make it configurable * Revamps module and tests, adds config * Adds more config and documentation * Updates mock emotion --------- Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: dmytro-po <[email protected]>
* Qortex RTD module code removal & cleanup * Add additional information to jsdocs * JSDocs update for setters
* 10432 Accept null floors * lint fix * Adding tests for floor provider case * null-safe getFloor in adapters * Update kargoBidAdapter.js --------- Co-authored-by: Marcin Komorski <[email protected]> Co-authored-by: Patrick McCann <[email protected]>
…in bidTimeoutHandler (prebid#12526)
* Delay auction param on currency module * hookConfig change * test improvement * review fixes * introducing timeoutQueue * fix --------- Co-authored-by: Marcin Komorski <[email protected]>
prebid#12537) * Update richaudienceBidAdapter.md Update maintainer e-mail to [email protected] * Add richaudienceBidAdapter.js file * Add richaudienceBidAdapter_spec.js * Update richaudienceBidAdapter.js * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA * Richaudience Bid Adapter: update adomain * Richaudience Bid Adapter: update adomain test * (fix)richAudienceBidAdapter change functionality of bid param: keywords --------- Co-authored-by: Patrick McCann <[email protected]> Co-authored-by: sergigimenez <[email protected]>
…#12532) * Added TTL Validation for Suppressing Expired Ads * resolved linting issues --------- Co-authored-by: pm-azhar-mulla <[email protected]>
* add support of dsa * restore topics * DSA fix for UT * drafy of adapter * fixes after dev test * make world simpler * fix prev commit * return empty userSyncs array by default * adjustments * apply prettier * unit tests for Equativ adapter * add dsp user sync * add readme * body can be undef * support additional br params * remove user sync * do not send dt param * handle floors and network id * handle empty media types * get min floor * fix desc for u.t. * better name for u.t. * add u.t. for not supported media type * improve currency u.t. * SADR-6484: initial video setup for new PBJS adapter * SADR-6484: Adding logging requirement missed earlier * SADR-6484: handle ext.rewarded prop for video with new oRTBConverter * SADR-6484: test revision + not sending bid requests where video obj is empty * refactoring and u.t. * rename variable * revert changes rel. to test endpoint * revert changes rel. to test endpoint * split imp[0] into seperate requests and fix u.t. --------- Co-authored-by: Elżbieta SZPONDER <[email protected]> Co-authored-by: eszponder <[email protected]> Co-authored-by: janzych-smart <[email protected]> Co-authored-by: Jeff Mahoney <[email protected]> Co-authored-by: Jeff Mahoney <[email protected]>
* cleanup currency poc * update * update * update * update * fix * investigation * review fixes * Do not change ortbConverter priority * Update admaticBidAdapter.js * Update missenaBidAdapter.js * Update missenaBidAdapter.js * Update admaticBidAdapter.js * lint fix --------- Co-authored-by: Marcin Komorski <[email protected]> Co-authored-by: Marcin Komorski <[email protected]> Co-authored-by: Demetrio Girardi <[email protected]> Co-authored-by: Patrick McCann <[email protected]>
* Add bidmatic syncs * Add bidmatic syncs
…#12497) * Missena Bid Adapter : refactor getUserSyncs * send screen
* Add goldfishAdsRtdProvider Module * Update description and change instances of GoldfishAds to Goldfish Ads * update names * Fix typo in goldfishAdsRtdProvider.md
* Mobkoi Bidder Adapter: Initialise implementation * feat: max-970: Prebid.js Bidder Adapter: Retrieve Adapter Parameters from Bid Configuration Object (#8) Configuration Object](https://mobkoi.atlassian.net/browse/MAX-970) At this stage, we are only focused on bid win events, so there is no need for analytics adapter integration yet. To streamline the publisher's configuration for our custom bid adapter integration, we retrieve adapter parameters directly from the bid configuration object instead of using "bidderConfiguration." updated bid adapter doc * feat: max-956: We need the placement ID from Tag and HB Connector to be past to the AdServer (#9) ### [We need the placement ID from Tag and HB Connector to be past to the AdServer](https://mobkoi.atlassian.net/browse/MAX-956) * set user.id if available
* feat: max-848 Prebid: setup development harness. max-849: Prebid: Make prebid RTB ORTB request to /bid (#1) harness](https://mobkoi.atlassian.net/browse/MAX-848) Set up a local development environment for testing and iterating on Prebid customization changes. Sub-tasks: Install Prebid.js dependencies. Create a custom Prebid.js Adapter (mobkoiBidAdapter) and build a custom Prebid.js package to serve locally (the custom Prebid.js package is available to serve to a local webpage). Initialize Ad Service Bid endpoint, ensuring it can serve dummy bid objects to the client. Initialize Ad Server Ad endpoint to serve dummy ads/creatives that display on the sample website. Set up a sample website for end-to-end testing, including page load, Prebid.js, Ad Service Bid endpoint, returning bids to the front-end, Ad Server Ad endpoint, and loading ads on the page. /bid](https://mobkoi.atlassian.net/browse/MAX-849) Update Prebid.js to create ORTB-formatted bid requests for the /bid endpoint. Sub-tasks: Modify Prebid request formatting to ORTB. Validate bid responses from /bid with ORTB formatting. Integrate the new ORTB bid request structure in the /bid endpoint base on the data provided by Prebid.js. Create unit tests. feat: max-852: Prebid: Log bid win to adserver (#3) > Related PRs mobkoi/adserver#6 adserver](https://mobkoi.atlassian.net/browse/MAX-852) Implement logging of bid wins directly to the ad server. Sub-tasks: Capture winning bid events in the Prebid.js custom adapter in various steps of biding process. feat: max-853: Prebid: Log bid loss to adserver (#4) adserver](https://mobkoi.atlassian.net/browse/MAX-853) Implement logging of failed bid events for monitoring purposes. Sub-tasks: Initialise a Prebid custom analytic adapter. Capture bid failure events within Prebid.js during various steps of the bidding process Initialise the endpoint for receiving bid loss signals. Logs will log into Grafana, but this will be done in a separate ticket feat: max-876: Prebid: Analytic Adapter Log debug info to adserver (#5) > Related PR: mobkoi/adserver#10 adserver](https://mobkoi.atlassian.net/browse/MAX-876) Add logging for debugging information to assist with monitoring and troubleshooting. Sub-tasks Record events at different stages of bid processing on the client side via the custom analytic adapter Save event messages locally on the client. Tag each message with one of three levels: info, warn, or debug. feat: writing unit tests for mobkoi adapters (#6) Co-authored-by: nvkftw <[email protected]> updated doc description added the missing mobkoiBidAdapter md small fix for our unit test added intergration with mobkoi getuid and setuid endpoint double encoded the setuid callback added mobkoiIdSystem module got a working smartadserver sync url from provided example got a working equativ url before rollback to ajax call for equativ intergration WIP testing droping pixel in iframe feat: max-970: Prebid.js Bidder Adapter: Retrieve Adapter Parameters from Bid Configuration Object (#8) Configuration Object](https://mobkoi.atlassian.net/browse/MAX-970) At this stage, we are only focused on bid win events, so there is no need for analytics adapter integration yet. To streamline the publisher's configuration for our custom bid adapter integration, we retrieve adapter parameters directly from the bid configuration object instead of using "bidderConfiguration." updated bid adapter doc wip equativ pixel in an iframe approvated concept cookie sync work on client side code tidy up for the working cookie solution removed the need for cookieName param matches the backend endpoint name changes feat: max-956: We need the placement ID from Tag and HB Connector to be past to the AdServer (#9) the AdServer](https://mobkoi.atlassian.net/browse/MAX-956) removed unexpected code transfer the user id to ortb2 request body and set the field to null if not avaiable fixed a minor bug enabed consent string added unit tests for mobkoi ID system module fixed a minor bug removed the code that wrapping URL in URL objects. It just make things complicated fixed the publisher ID in macro issue clean up branch for offical PR pass the expiration value when setting storage using the storage manager updated id system module md pass expire setting to storage * code tidy up * switch to getStorageManager instead of getCoreStorageManager * add mobkoiIdSystem to modules/.submodules.json file
* AGT-399: GAM reporting integration * AGT-399: Description for new parameters * AGT-399: Some fixes after review, gamParameterName test * AGT-399: Change version * AGT-399: Fix linter
prebid#12720) * 12512 Mock bid responses for various media types * lint fix * resolvers execution fix * + basic examples * comments * adapt native to ortb & refactor video example * moving renderer to bid response
* Audiencelogy Bid Adapter : Initial Release * removed duplicates * removed duplicates * added common code in library libraries/audiencelogyUtils * solved linter issues * imported getRequest from library and solved linting issue * solved trailing space issue * new adapter : lane4 * new adapter : lane4 * removed linter errors * removed trailing space
* Update ozoneBidAdapter_spec.js spectests updated * Update ozoneBidAdapter.js - fixed a bug with getFloors - we need to take the first index [0] of sizes - changed instances of Array.isArray to isArray * Update ozoneBidAdapter.js * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.js removed trailing space * Update ozoneBidAdapter.js
…d#12741) * ADTS-530-send-content-url-from-prebid-adapter-to-hbid-endpoint * added tests for new params and converted array params to strings * changed comment for rebuild * added support for playbackmethod for video ads * added support for playbackend * modified curl to only be added if present --------- Co-authored-by: John Bauzon <[email protected]>
…t to verify segtax 7 functionality (prebid#12794)
* Core: suspend auctions during prerendering * Delay only auctions by default * add option to delay queue --------- Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: Alexandr Kim <[email protected]>
github-mathieu-capo
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
teads-antoine-azar
pushed a commit
that referenced
this pull request
Feb 24, 2025
) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (prebid#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (prebid#14) * Update getUid function to check for pubcid and sharedid * updates adapter version * [RPO-3405] Add browserLanguage to request meta object * ConcertBidAdapter: Add TDID (prebid#20) * Add tdid to meta object * Fix null handling and add tests * Concert Bid Adapter: Add dealId Property to Bid Responses (prebid#22) * adds dealid property to bid responses * updates tests * use first bid for tests * adds dealid at the correct level --------- Co-authored-by: antoin <[email protected]> Co-authored-by: Antoin <[email protected]> Co-authored-by: Sam Ghitelman <[email protected]> Co-authored-by: Sam Ghitelman <[email protected]>
* wip * chore: update ENDPOINT_URL * chore: update permission for localstorage * feat(bmsBidAdapter): implement bid floor logic and update request structure * test(bmsBidAdapter): remove commented-out tests for interpretResponse * wip * wip * Refactor geolocation implementationn * chore: minor adjustments * feat: add bidWon * update test * chore: Change double quotes to single quotes * Update creativeId and creative_id values * refactor: remove unused cookie ID handling from bid request * wip * Remove deprecated BMS sample HTML and update BMS bid adapter to use JSON.stringify for requests and sendBeacon for bid won notifications * wip * Update creative.html * Update creative.html --------- Co-authored-by: Patrick McCann <[email protected]>
be6a507
to
c8cc9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding two new fields in the payload :
domComplexity
which is based on querying the number of elements in the pagenetworkQuality
based onconnection.effectiveType
Adapter maintainer : [email protected]