Skip to content

Allow v241 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Allow v241 #30

merged 2 commits into from
Apr 4, 2024

Conversation

rrjjvv
Copy link
Contributor

@rrjjvv rrjjvv commented Apr 4, 2024

Fixes #29

I hit this with regular Intellij, but had an old copy of PyCharm as well and validated it loads there as well.

rrjjvv added 2 commits April 4, 2024 12:08
The original sha can be found in the GitHub UI, but not resolvable by earthly; I'm assuming its only reachable by the PR ref but was then squashed on merge.  This updated sha is the for the merge commit of that PR (earthly/lib#37)
@rrjjvv rrjjvv requested a review from a team as a code owner April 4, 2024 18:19
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@idodod idodod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@idodod idodod merged commit 1571171 into earthly:main Apr 4, 2024
1 check passed
@rrjjvv rrjjvv deleted the allow-v241 branch April 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make it compatible with w/ PyCharm v. 2024.1
3 participants