Additional layout fixes #1058
Merged
Additional layout fixes #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
line-o
commented
Jan 9, 2025
line-o
commented
- tables have proper headings which also fixes the row backgrounds to start with the brighter color
- definition lists, used in many articles, did overflow their container and thus broke the page layout
- code blocks have rounded edges and a subtle thin border to nicely integrate into the overall page
- fixed the background size of the "powered by" element at the bottom
- add some comments to SCSS
- some tables were missing headers completely and some had them in the content - since they are striped they started with the darker color instead of the lighter one - remove some unnecessary CSS rules
reinhapa
approved these changes
Jan 9, 2025
duncdrum
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.