Avoid data races between ReceiverResource and Participant initialization [7475] #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Build status:
|
|
Build status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ReceiverResources are registered during the RTPSParticipantImpl construction, they may start receiving data before the Participant initialization is finished, causing a system crash.
This PR delays the registering the ReceiverResource until RTPSParticipantImpl::enable.
A new parameter on RTPSParticipantImpl::createReceiverResources specifies if the resource registration should be defered (for example, on resources created on initialization) or performed immediately (for resources created after initialization).