Skip to content

[22972] Support sequences in IDL Parser #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2025
Merged

[22972] Support sequences in IDL Parser #5763

merged 6 commits into from
Apr 23, 2025

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Apr 14, 2025 •
edited by Javgilavi
Loading

Description

This PR adds support for parsing sequence types in IDL Parser. It also moves state["type"] updates to scope_name action to parse scoped types correctly. Union types parsing has been refactored to be similar to array types parsing.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR:
  • [22972] Support sequences in IDL Parser Fast-DDS-docs#1054
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-sequences branch 4 times, most recently from ace02d4 to 32a7bbe Compare April 15, 2025 08:28
@Javgilavi Javgilavi self-requested a review April 15, 2025 14:15
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 15, 2025
@Javgilavi
Copy link
Contributor

Everything looks good, and the CI has pass green.

I leave some proposed minor changes to comments and a little on code.

Also, please add the milestone and put N/A on the checklist values that doesn't apply

@Carlosespicur Carlosespicur added this to the v3.3.0 milestone Apr 21, 2025
@Carlosespicur Carlosespicur marked this pull request as ready for review April 21, 2025 13:11
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-sequences branch 2 times, most recently from cc65f91 to 7dc4084 Compare April 21, 2025 13:21
@Carlosespicur
Copy link
Contributor Author

Everything looks good, and the CI has pass green.

I leave some proposed minor changes to comments and a little on code.

Also, please add the milestone and put N/A on the checklist values that doesn't apply

Changes applied on 7dc4084

@Carlosespicur Carlosespicur requested a review from Javgilavi April 21, 2025 13:24
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi April 21, 2025 13:39
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-sequences branch from 856b9ac to 0350779 Compare April 21, 2025 13:42
@Carlosespicur Carlosespicur mentioned this pull request Apr 21, 2025
Merged
6 tasks
@Carlosespicur Carlosespicur requested review from Javgilavi and removed request for Javgilavi April 21, 2025 13:50
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi April 21, 2025 13:50
@Carlosespicur Carlosespicur modified the milestones: v3.3.0, v3.2.2 Apr 21, 2025
Javgilavi
Javgilavi approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Javgilavi Javgilavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Javgilavi Javgilavi added skip-ci Automatically pass CI ci-pending PR which CI is running and removed ci-pending PR which CI is running skip-ci Automatically pass CI labels Apr 22, 2025
@Carlosespicur Carlosespicur requested a review from Javgilavi April 22, 2025 12:22
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-sequences branch from 0350779 to 9df88b3 Compare April 22, 2025 12:28
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi April 22, 2025 12:31
@rsanchez15 rsanchez15 requested review from Javgilavi and removed request for Javgilavi April 22, 2025 12:39
@Javgilavi Javgilavi merged commit e0481cd into master Apr 23, 2025
18 of 31 checks passed
@Javgilavi Javgilavi deleted the feature/idl-parser-sequences branch April 23, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Javgilavi Javgilavi Awaiting requested review from Javgilavi

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Carlosespicur @Javgilavi