Skip to content

[23048] Fix related_sample_identity handling in RPC entities #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 11, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Apr 11, 2025

Description

This PR fixes the way related_sample_identity is handled in ReplierImpl and RequesterImpl for cases where it already has a value when the request is performed.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.2.2 milestone Apr 11, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 11, 2025
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur April 11, 2025 07:44
@MiguelCompany MiguelCompany changed the title [23048] Fix related_sample_identity handling in ReplierImpl [23048] Fix related_sample_identity handling in RPC entities Apr 11, 2025
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima April 11, 2025 07:46
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima April 11, 2025 07:52
@MiguelCompany MiguelCompany merged commit f6094b6 into master Apr 11, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23048 branch April 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants