Skip to content

[22995] Fix MacOS nightly flaky tests #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

[22995] Fix MacOS nightly flaky tests #5738

merged 2 commits into from
Apr 1, 2025

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Mar 31, 2025 •
edited by MiguelCompany
Loading

Description

This PR provides some fixes in a couple of tests failing in the nighties

@Mergifyio backport 3.1.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.1 milestone Mar 31, 2025
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima March 31, 2025 17:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 31, 2025
@Mario-DL Mario-DL changed the title [22995] Fix MacOS flaky tests [22995] Fix MacOS nightly flaky tests Apr 1, 2025
@MiguelCompany MiguelCompany merged commit 6d0d853 into master Apr 1, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the fix/22995 branch April 1, 2025 07:26
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2025 •
edited
Loading

backport 3.1.x 2.14.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 1, 2025
@Mario-DL @mergify
Fix MacOS nightly flaky tests (#5738)
c1b9d1a 
* Refs #22995: Fix extended monitor service qos BB test

Signed-off-by: Mario Domínguez López <[email protected]>

* Refs #22955: Fix single_unicast_pdp_response_flowcontroller for a single threaded system

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Domínguez López <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6d0d853)

# Conflicts:
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
#	test/blackbox/common/DDSBlackboxTestsMonitorService.cpp
@mergify mergify bot mentioned this pull request Apr 1, 2025
Closed
11 tasks
mergify bot pushed a commit that referenced this pull request Apr 1, 2025
@Mario-DL @mergify
Fix MacOS nightly flaky tests (#5738)
dca5ad5 
* Refs #22995: Fix extended monitor service qos BB test

Signed-off-by: Mario Domínguez López <[email protected]>

* Refs #22955: Fix single_unicast_pdp_response_flowcontroller for a single threaded system

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Domínguez López <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6d0d853)

# Conflicts:
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
#	test/blackbox/common/DDSBlackboxTestsMonitorService.cpp
@mergify mergify bot mentioned this pull request Apr 1, 2025
Closed
11 tasks
mergify bot pushed a commit that referenced this pull request Apr 1, 2025
@Mario-DL @mergify
Fix MacOS nightly flaky tests (#5738)
fad1d73 
* Refs #22995: Fix extended monitor service qos BB test

Signed-off-by: Mario Domínguez López <[email protected]>

* Refs #22955: Fix single_unicast_pdp_response_flowcontroller for a single threaded system

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Domínguez López <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6d0d853)

# Conflicts:
#	test/blackbox/common/BlackboxTestsDiscovery.cpp
#	test/blackbox/common/DDSBlackboxTestsMonitorService.cpp
@mergify mergify bot mentioned this pull request Apr 1, 2025
Closed
11 tasks
@Mario-DL Mario-DL mentioned this pull request Apr 4, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.1- Freeze ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany