Skip to content

IDL parsing tests included paths #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Mar 27, 2025

Description

This PR modifies the IDL parsing tests to make sure the include_paths parameter is actually required in the corresponding tests.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO: Any new/modified methods have been properly documented using Doxygen.
  • NO: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NO: New feature has been added to the versions.md file (if applicable).
  • NO: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 27, 2025
@EugenioCollado EugenioCollado added this to the v3.2.1 milestone Mar 27, 2025
Signed-off-by: Eugenio Collado <[email protected]>
@EugenioCollado EugenioCollado force-pushed the 22977/idl_parsing_include_paths_test branch from 2a57be5 to a5ca6ea Compare March 27, 2025 07:55
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 27, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 27, 2025 07:58
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 27, 2025
Signed-off-by: Eugenio Collado <[email protected]>
@EugenioCollado EugenioCollado removed the ci-pending PR which CI is running label Mar 31, 2025
@EugenioCollado EugenioCollado removed the request for review from richiprosima March 31, 2025 14:22
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 31, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EugenioCollado EugenioCollado added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 1, 2025
@MiguelCompany MiguelCompany merged commit 794d84b into master Apr 1, 2025
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the 22977/idl_parsing_include_paths_test branch April 1, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants