Skip to content

[23006] Reduce trace category when failing to unregister type #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Mar 26, 2025

Description

PR #5687 added a log error trace to DomainParticipantImpl::unregister_type when attempting to unregister a type that is still being used. As a consequence, several log traces started to appear when deleting ROS 2 nodes, since unregister_type gets called by rmw_fastrtps_shared_cpp::remove_topic_and_type when destroying publications and subscriptions, regardless of whether the type is still being used by other publications/subscriptions. This can make tests checking for error traces to fail, which can be avoided by just reducing the log category.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanlofer-eprosima juanlofer-eprosima added this to the v3.2.1 milestone Mar 26, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 26, 2025
@juanlofer-eprosima juanlofer-eprosima removed the request for review from richiprosima March 26, 2025 10:10
@MiguelCompany MiguelCompany self-requested a review March 26, 2025 10:31
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the following green:

  • Linux Build Status

@MiguelCompany MiguelCompany merged commit ef6f353 into master Mar 26, 2025
21 of 31 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/unregister-type-trace branch March 26, 2025 16:01
@juanlofer-eprosima juanlofer-eprosima changed the title Reduce trace category when failing to unregister type [23006] Reduce trace category when failing to unregister type Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants