-
Notifications
You must be signed in to change notification settings - Fork 816
[22876] Extend QoS in discovery data #5712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader/Writer Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…tures and new PIDs Signed-off-by: Mario Dominguez <[email protected]>
…Reader/Writer Signed-off-by: Mario Dominguez <[email protected]>
…/Writer Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Mar 19, 2025
include/fastdds/rtps/builtin/data/PublicationBuiltinTopicData.hpp
Outdated
Show resolved
Hide resolved
include/fastdds/rtps/builtin/data/SubscriptionBuiltinTopicData.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Mar 19, 2025
test/mock/rtps/WriterProxyData/rtps/builtin/data/WriterProxyData.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the QoS in the discovery data of the different entities as
fastcdr::optional
.It also includes serialization/deserialization specialization for the added QoS.
Related PRs
optional
copy/move constructors actuate only if the storage is engaged Fast-CDR#264Note: A follow-up PR shall include: serialization of
WireProtocolConfigQoS
, a mechanism to serialize only non-default qos in the discovery data and their BB testsContributor Checklist
versions.md
file (if applicable).Reviewer Checklist