Skip to content

[22876] Extend QoS in discovery data #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2025
Merged

[22876] Extend QoS in discovery data #5712

merged 10 commits into from
Mar 20, 2025

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Mar 18, 2025

Description

This PR extends the QoS in the discovery data of the different entities as fastcdr::optional.
It also includes serialization/deserialization specialization for the added QoS.

Related PRs

Note: A follow-up PR shall include: serialization of WireProtocolConfigQoS, a mechanism to serialize only non-default qos in the discovery data and their BB tests

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Mar 18, 2025
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany March 18, 2025 14:30
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 18, 2025
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany March 19, 2025 07:53
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany March 19, 2025 11:33
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany March 19, 2025 14:03
Signed-off-by: Mario Dominguez <[email protected]>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima March 19, 2025 15:52
@MiguelCompany MiguelCompany merged commit 28cc40c into master Mar 20, 2025
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/22876 branch March 20, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants