Skip to content

[22931] Fix assertion on OutputTrafficManager #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2025
Merged

[22931] Fix assertion on OutputTrafficManager #5704

merged 5 commits into from
Mar 18, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 12, 2025 •
edited
Loading

Description

This PR ensures that OpenOutputChannel is called in the transports for every locator that might be used by any reader or writer.

@Mergifyio backport 3.1.x 2.14.x 2.10.x

@Mergifyio backport 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Mar 12, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima March 12, 2025 15:46
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 12, 2025
@cferreiragonz cferreiragonz force-pushed the bugfix/22930 branch 4 times, most recently from dc96401 to 490f1be Compare March 17, 2025 16:04
@MiguelCompany MiguelCompany marked this pull request as ready for review March 17, 2025 16:10
cferreiragonz
cferreiragonz approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 777a71b into master Mar 18, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22930 branch March 18, 2025 13:53
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.1.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025 •
edited
Loading

backport 3.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@MiguelCompany @mergify
Fix assertion on OutputTrafficManager (#5704)
f6e4f8d 
* Refs #22930. Add entry when missing on `set_statistics_message_data`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Create sender resources on stateless readers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Similar changes on writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930: Test TCP with best effort reader

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22930: Uncrustify

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Co-authored-by: cferreiragonz <[email protected]>
(cherry picked from commit 777a71b)

# Conflicts:
#	src/cpp/rtps/reader/StatelessReader.cpp
#	src/cpp/rtps/writer/StatelessWriter.cpp
@mergify mergify bot mentioned this pull request Mar 18, 2025
Merged
13 tasks
MiguelCompany added a commit that referenced this pull request Mar 18, 2025
@mergify @MiguelCompany
Fix assertion on OutputTrafficManager (#5704) (#5711)
2c7e56f 
* Fix assertion on `OutputTrafficManager` (#5704)

* Refs #22930. Add entry when missing on `set_statistics_message_data`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Create sender resources on stateless readers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Similar changes on writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930: Test TCP with best effort reader

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22930: Uncrustify

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Co-authored-by: cferreiragonz <[email protected]>
(cherry picked from commit 777a71b)

# Conflicts:
#	src/cpp/rtps/reader/StatelessReader.cpp
#	src/cpp/rtps/writer/StatelessWriter.cpp

* Fix conflicts

---------

Co-authored-by: Miguel Company <[email protected]>
mergify bot added a commit that referenced this pull request Mar 18, 2025
@mergify
Fix assertion on OutputTrafficManager (#5704) (#5711)
59147e5 
* Fix assertion on `OutputTrafficManager` (#5704)

* Refs #22930. Add entry when missing on `set_statistics_message_data`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Create sender resources on stateless readers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Similar changes on writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930: Test TCP with best effort reader

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22930: Uncrustify

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Co-authored-by: cferreiragonz <[email protected]>
(cherry picked from commit 777a71b)

# Conflicts:
#	src/cpp/rtps/reader/StatelessReader.cpp
#	src/cpp/rtps/writer/StatelessWriter.cpp

* Fix conflicts

---------

Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 2c7e56f)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.h
#	src/cpp/statistics/rtps/messages/OutputTrafficManager.hpp
@mergify mergify bot mentioned this pull request Mar 18, 2025
Open
13 tasks
mergify bot added a commit that referenced this pull request Mar 18, 2025
@mergify
Fix assertion on OutputTrafficManager (#5704) (#5711)
73d6d2a 
* Fix assertion on `OutputTrafficManager` (#5704)

* Refs #22930. Add entry when missing on `set_statistics_message_data`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Create sender resources on stateless readers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930. Similar changes on writers.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22930: Test TCP with best effort reader

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22930: Uncrustify

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Co-authored-by: cferreiragonz <[email protected]>
(cherry picked from commit 777a71b)

# Conflicts:
#	src/cpp/rtps/reader/StatelessReader.cpp
#	src/cpp/rtps/writer/StatelessWriter.cpp

* Fix conflicts

---------

Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 2c7e56f)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
#	src/cpp/rtps/participant/RTPSParticipantImpl.h
#	src/cpp/rtps/writer/StatelessWriter.cpp
#	src/cpp/statistics/rtps/messages/OutputTrafficManager.hpp
@mergify mergify bot mentioned this pull request Mar 18, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @cferreiragonz