[22210] Handle socket buffer size setting when system's maximum exceeded (backport #5527) #5561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
12 tasks
Mario-DL
approved these changes
Jan 21, 2025
Mario-DL
added
ready-to-merge
|
Giving another preemptive asan test rerun |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Javgilavi
force-pushed
the
mergify/bp/3.0.x/pr-5527
branch
from
05c113b to
6424c12
Compare
|
@Mergifyio rebase |
* Regression tests for asio_helpers socket buffer size Signed-off-by: Eugenio Collado <[email protected]> * Regression tests udp & tcp Signed-off-by: Eugenio Collado <[email protected]> * Refs #22210. Ensure that actual set value is returned by `asio_helpers::try_setting_buffer_size` Signed-off-by: Miguel Company <[email protected]> * Fix corner case infinite loop Signed-off-by: Eugenio Collado <[email protected]> * Uncrustify Signed-off-by: Eugenio Collado <[email protected]> * Fix UDP tests Signed-off-by: Eugenio Collado <[email protected]> * Fix windows compilation Signed-off-by: Eugenio Collado <[email protected]> * Applied suggestions to regression test Signed-off-by: Eugenio Collado <[email protected]> * Applied suggestions to udp tests Signed-off-by: Eugenio Collado <[email protected]> * Uncrustify Signed-off-by: Eugenio Collado <[email protected]> --------- Signed-off-by: Eugenio Collado <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 5fc7786)
Signed-off-by: Mario Dominguez <[email protected]>
✅ Branch has been successfully rebased |
Javgilavi
force-pushed
the
mergify/bp/3.0.x/pr-5527
branch
from
6424c12 to
9a5aba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the socket buffer size configuration mechanism. Previously, the try_setting_buffer_size method relied on the error code returned by the ASIO API to verify successful changes, which proved unreliable as no error code was returned even when the operation failed. The method has been updated to validate the buffer size by checking the actual size after setting the option, ensuring correct configuration or at least returning the actual final_buffer_value.
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
NA: Any new/modified methods have been properly documented using Doxygen.
NA: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
NA: New feature has been added to the
versions.mdfile (if applicable).NA: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5527 done by [Mergify](https://mergify.com).