Skip to content

[21913] Make DomainParticipant creation fail if MaxMessageSize is lower than PDP package size #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Dec 9, 2024

Description

Make RTPS participant creation fail in case the maximum message size in the transport is lower than the PDP package size.

Merge after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado added this to the v3.2.0 milestone Dec 9, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 9, 2024
@EugenioCollado EugenioCollado force-pushed the fix/21814 branch 3 times, most recently from 63e6bdc to a92ba0f Compare December 16, 2024 07:08
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima December 16, 2024 07:23
Base automatically changed from fix/21814 to master December 18, 2024 08:30
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima December 23, 2024 09:08
@EugenioCollado EugenioCollado added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Dec 31, 2024
@rsanchez15 rsanchez15 modified the milestones: v3.2.0, v3.3.0 Feb 25, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, and we are good to go!

Also please fill the description

@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Jun 13, 2025
EugenioCollado and others added 2 commits June 13, 2025 13:28
Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: EugenioCollado <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: EugenioCollado <[email protected]>
@MiguelCompany MiguelCompany self-requested a review June 13, 2025 11:39
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 13, 2025
@MiguelCompany MiguelCompany changed the title [21913] DomainParticipant creation fails if SHM MaxMessageSize is lower than minimum [21913] Make DomainParticipant creation fails MaxMessageSize is lower than PDP package size Jun 13, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EugenioCollado EugenioCollado changed the title [21913] Make DomainParticipant creation fails MaxMessageSize is lower than PDP package size [21913] Make DomainParticipant creation fail if MaxMessageSize is lower than PDP package size Jun 17, 2025
@EugenioCollado EugenioCollado merged commit 15e3ab5 into master Jun 17, 2025
24 of 25 checks passed
@EugenioCollado EugenioCollado deleted the fix/21913 branch June 17, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants