Skip to content

[22343] Bugfix: Add pointer sanity check before accessing ParticipantProxyData #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 28, 2024

Description

#5257 introduced a disposal guid mangling in secure clients.
This PR fixes a Secure PDPClient null pointer check when when accessing the local participant proxy data.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.14.5 milestone Nov 28, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 28, 2024 10:58
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 28, 2024
@MiguelCompany MiguelCompany merged commit df80e44 into 2.14.x Dec 4, 2024
17 of 18 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22343 branch December 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants