Skip to content

[21891] Correct examples on README #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

Javgilavi
Copy link
Contributor

@Javgilavi Javgilavi commented Nov 26, 2024

Description

Delate benchmark example from the README until it get completed.
Also I updated the command to execute "hello_world" in the README to use the new version.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Javier Gil Aviles <[email protected]>
@Javgilavi Javgilavi added this to the v3.2.0 milestone Nov 26, 2024
@rsanchez15 rsanchez15 self-requested a review November 27, 2024 07:21
@rsanchez15 rsanchez15 requested review from rsanchez15 and richiprosima and removed request for rsanchez15 and richiprosima November 27, 2024 09:44
@rsanchez15 rsanchez15 added the skip-ci Automatically pass CI label Nov 27, 2024
@rsanchez15 rsanchez15 merged commit 9d3753c into master Nov 27, 2024
3 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/readme-examples branch November 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants