Skip to content

[21696] Fix SecurityManager assertion in Secure DS #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

[21696] Fix SecurityManager assertion in Secure DS #5329

merged 2 commits into from
Oct 30, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR addresses an assertion triggering in the SecurityManager as a consequence of not being able to retrieve a new change for the participant_stateless_msg_writer

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #21696: Add regression test
3011526 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Refs #21696: Add fix
1aa77f8 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added this to the v3.1.1 milestone Oct 16, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 16, 2024 11:37
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 16, 2024
@JesusPoderoso JesusPoderoso modified the milestones: v3.1.1, v3.2.0 Oct 17, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 30, 2024
@MiguelCompany MiguelCompany merged commit ce72a14 into master Oct 30, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/21696 branch October 30, 2024 17:15
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@Mario-DL @mergify
Fix SecurityManager assertion in Secure DS (#5329)
1abe4a2 
* Refs #21696: Add regression test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21696: Add fix

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ce72a14)
@mergify mergify bot mentioned this pull request Oct 30, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@Mario-DL @mergify
Fix SecurityManager assertion in Secure DS (#5329)
9cee5c1 
* Refs #21696: Add regression test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21696: Add fix

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ce72a14)
@mergify mergify bot mentioned this pull request Oct 30, 2024
Merged
14 tasks
MiguelCompany pushed a commit that referenced this pull request Nov 14, 2024
@mergify @Mario-DL
Fix SecurityManager assertion in Secure DS (#5329) (#5370)
a13cf60 
* Refs #21696: Add regression test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21696: Add fix

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ce72a14)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Nov 14, 2024
@mergify @Mario-DL
Fix SecurityManager assertion in Secure DS (#5329) (#5369)
6837c32 
* Refs #21696: Add regression test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21696: Add fix

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit ce72a14)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @MiguelCompany @JesusPoderoso