Skip to content

Branch out 3.0.x #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Branch out 3.0.x #5286

merged 5 commits into from
Oct 2, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 2, 2024

Description

Branching out 3.0.x branch after turning master into 3.1.x on #5285

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Oct 2, 2024
@MiguelCompany MiguelCompany added this to the v3.0.2 milestone Oct 2, 2024
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Oct 2, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 2, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the fallback_branch in the reusable-* workflows ?

@MiguelCompany
Copy link
Member Author

Should we also change the fallback_branch in the reusable-* workflows ?

It seems this is only necessary on reusable-ubuntu-ci.yml

@MiguelCompany MiguelCompany requested review from Mario-DL and removed request for JesusPoderoso October 2, 2024 07:11
@MiguelCompany
Copy link
Member Author

Should we also change the fallback_branch in the reusable-* workflows ?

It seems this is only necessary on reusable-ubuntu-ci.yml

Done in a838371

Mario-DL
Mario-DL previously approved these changes Oct 2, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 93fc3cb into 3.0.x Oct 2, 2024
14 checks passed
@MiguelCompany MiguelCompany deleted the branchout/3.0.x branch October 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running first-to-merge no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants