[17283] Fix issues in Dynamic Network Interfaces #5282

MiguelCompany · 2024-09-30T15:08:02Z

Description

This PR adds a regression test based in Ubuntu containers for one long standing issue with dynamic network interfaces that was preventing communication when a participant was created with no network interfaces available.

It fixes the issue by correctly updating the locators on the proxy data of the participant, and all its readers or writers created with the default locators.

@Mergifyio backport 3.0.x 2.14.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <[email protected]>

…ult_nts`. Signed-off-by: Miguel Company <[email protected]>

Signed-off-by: Miguel Company <[email protected]>

test/dds/communication/PublisherMain.cpp

test/dds/communication/SubscriberMain.cpp

test/dds/communication/PublisherMain.cpp

test/dds/communication/dyn_network/CMakeLists.txt

src/cpp/rtps/builtin/discovery/participant/PDP.cpp

…_update_nts`. Signed-off-by: Miguel Company <[email protected]>

Signed-off-by: Miguel Company <[email protected]>

JesusPoderoso

LGTM with green CI

MiguelCompany · 2024-10-04T05:43:21Z

@Mergifyio backport 3.0.x 2.14.x

mergify · 2024-10-04T05:43:30Z

backport 3.0.x 2.14.x

✅ Backports have been created

#5303 [17283] Fix issues in Dynamic Network Interfaces (backport #5282) has been created for branch 3.0.x
#5304 [17283] Fix issues in Dynamic Network Interfaces (backport #5282) has been created for branch 2.14.x but encountered conflicts

* Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8)

* Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) # Conflicts: # include/fastdds/rtps/builtin/discovery/participant/PDP.h # src/cpp/rtps/builtin/discovery/participant/PDP.cpp # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/dds/communication/PublisherModule.hpp # test/dds/communication/SubscriberModule.hpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.hpp

* Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) Co-authored-by: Miguel Company <[email protected]>

* Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8)

* Fix issues in Dynamic Network Interfaces (#5282) * Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) * Refs #17283: Fix conflicts Signed-off-by: eProsima <[email protected]> * Refs #17283: Keep original PR functionality Signed-off-by: eProsima <[email protected]> * Refs #17283: Please uncrustify Signed-off-by: eProsima <[email protected]> * Restore discovery server list check code. Signed-off-by: Miguel Company <[email protected]> * Make backported methods static methods instead of inline code. Signed-off-by: Miguel Company <[email protected]> * Methods get_default_xxx_locators with output argument. Signed-off-by: Miguel Company <[email protected]> * Only update attributes when necessary. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: eProsima <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> Co-authored-by: eProsima <[email protected]>

* Fix issues in Dynamic Network Interfaces (#5282) * Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) * Refs #17283: Fix conflicts Signed-off-by: eProsima <[email protected]> * Refs #17283: Keep original PR functionality Signed-off-by: eProsima <[email protected]> * Refs #17283: Please uncrustify Signed-off-by: eProsima <[email protected]> * Restore discovery server list check code. Signed-off-by: Miguel Company <[email protected]> * Make backported methods static methods instead of inline code. Signed-off-by: Miguel Company <[email protected]> * Methods get_default_xxx_locators with output argument. Signed-off-by: Miguel Company <[email protected]> * Only update attributes when necessary. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: eProsima <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> Co-authored-by: eProsima <[email protected]> (cherry picked from commit 66ec998) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/communication/PublisherMain.cpp # test/communication/SubscriberMain.cpp # test/dds/communication/SubscriberMain.cpp # test/dds/communication/SubscriberModule.hpp # test/dds/communication/security/PublisherModule.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.cpp # test/dds/communication/security/SubscriberModule.hpp

* Fix issues in Dynamic Network Interfaces (#5282) * Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) * Refs #17283: Fix conflicts Signed-off-by: eProsima <[email protected]> * Refs #17283: Keep original PR functionality Signed-off-by: eProsima <[email protected]> * Refs #17283: Please uncrustify Signed-off-by: eProsima <[email protected]> * Restore discovery server list check code. Signed-off-by: Miguel Company <[email protected]> * Make backported methods static methods instead of inline code. Signed-off-by: Miguel Company <[email protected]> * Methods get_default_xxx_locators with output argument. Signed-off-by: Miguel Company <[email protected]> * Only update attributes when necessary. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: eProsima <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> Co-authored-by: eProsima <[email protected]> (cherry picked from commit 66ec998) Signed-off-by: Miguel Company <[email protected]> # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/communication/PublisherMain.cpp # test/communication/SubscriberMain.cpp # test/dds/communication/SubscriberMain.cpp # test/dds/communication/SubscriberModule.hpp # test/dds/communication/security/PublisherModule.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.cpp # test/dds/communication/security/SubscriberModule.hpp

* Fix issues in Dynamic Network Interfaces (#5282) * Refs #21690. Parse `--rescan` argument on communication applications. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Implement rescan mechanism. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add docker infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add CMake infrastructure. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Ensure same domain and topic name are used. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add `--loops` argument to publisher. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Publisher exits after publishing all samples. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve subscriber script. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Make publisher wait subscriber. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Possible fix. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Clear locators before recalculating them. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Move local participant proxy update to PDP. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Improve new method's logic. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Include what you use. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add empty method to update endpoint locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Add implementation for `update_endpoint_locators_if_default_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Compare against old default locators. Signed-off-by: Miguel Company <[email protected]> * Refs #21690. Update locators in attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Avoid early return on `PDP::local_participant_attributes_update_nts`. Signed-off-by: Miguel Company <[email protected]> * Refs #17283. Apply suggestions. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 91bd7c8) * Refs #17283: Fix conflicts Signed-off-by: eProsima <[email protected]> * Refs #17283: Keep original PR functionality Signed-off-by: eProsima <[email protected]> * Refs #17283: Please uncrustify Signed-off-by: eProsima <[email protected]> * Restore discovery server list check code. Signed-off-by: Miguel Company <[email protected]> * Make backported methods static methods instead of inline code. Signed-off-by: Miguel Company <[email protected]> * Methods get_default_xxx_locators with output argument. Signed-off-by: Miguel Company <[email protected]> * Only update attributes when necessary. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: eProsima <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> Co-authored-by: eProsima <[email protected]> (cherry picked from commit 66ec998) Signed-off-by: Miguel Company <[email protected]> # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # test/communication/PublisherMain.cpp # test/communication/SubscriberMain.cpp # test/dds/communication/SubscriberMain.cpp # test/dds/communication/SubscriberModule.hpp # test/dds/communication/security/PublisherModule.cpp # test/dds/communication/security/PublisherModule.hpp # test/dds/communication/security/SubscriberModule.cpp # test/dds/communication/security/SubscriberModule.hpp Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

MiguelCompany added this to the v3.0.2 milestone Sep 30, 2024

MiguelCompany requested a review from richiprosima September 30, 2024 19:09

github-actions bot added the ci-pending PR which CI is running label Sep 30, 2024

MiguelCompany force-pushed the bugfix/21690 branch from 35b1a2f to 5595cfe Compare October 1, 2024 05:56

MiguelCompany requested review from richiprosima and removed request for richiprosima October 1, 2024 06:04

MiguelCompany added 2 commits October 1, 2024 11:50

Refs #21690. Parse --rescan argument on communication applications.

f4177dc

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Implement rescan mechanism.

c901d7a

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany force-pushed the bugfix/21690 branch from 5595cfe to 9d88575 Compare October 1, 2024 09:50

MiguelCompany added 17 commits October 1, 2024 12:05

Refs #21690. Add docker infrastructure.

0ac94ca

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Add CMake infrastructure.

d4a2a7a

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Ensure same domain and topic name are used.

ea60f90

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Add --loops argument to publisher.

35d0424

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Publisher exits after publishing all samples.

f6ede02

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Improve subscriber script.

77fef7a

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Add test.

13ecf3c

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Make publisher wait subscriber.

1682174

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Possible fix.

811c39b

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Clear locators before recalculating them.

28f5093

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Move local participant proxy update to PDP.

edbba1c

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Improve new method's logic.

89d0d66

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Include what you use.

42013fc

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Add empty method to update endpoint locators.

dc2ef2c

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Add implementation for `update_endpoint_locators_if_defa…

bfa66a1

…ult_nts`. Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Compare against old default locators.

9582f1a

Signed-off-by: Miguel Company <[email protected]>

Refs #21690. Update locators in attributes.

986acc4

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany force-pushed the bugfix/21690 branch from 9d88575 to 986acc4 Compare October 1, 2024 10:05

MiguelCompany requested review from richiprosima and removed request for richiprosima October 1, 2024 10:13

MiguelCompany removed this from the v3.0.2 milestone Oct 2, 2024

MiguelCompany added this to the v3.1.0 milestone Oct 2, 2024

JesusPoderoso suggested changes Oct 3, 2024

View reviewed changes

MiguelCompany added 2 commits October 3, 2024 16:46

Refs #17283. Avoid early return on `PDP::local_participant_attributes…

77a37a1

…_update_nts`. Signed-off-by: Miguel Company <[email protected]>

Refs #17283. Apply suggestions.

407c552

Signed-off-by: Miguel Company <[email protected]>

MiguelCompany requested a review from JesusPoderoso October 3, 2024 14:50

JesusPoderoso approved these changes Oct 3, 2024

View reviewed changes

JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 4, 2024

MiguelCompany merged commit 91bd7c8 into master Oct 4, 2024
16 of 17 checks passed

MiguelCompany deleted the bugfix/21690 branch October 4, 2024 05:43

This was referenced Oct 4, 2024

[17283] Fix issues in Dynamic Network Interfaces (backport #5282) #5303

Merged

[17283] Fix issues in Dynamic Network Interfaces (backport #5282) #5304

Merged

richiware mentioned this pull request Oct 8, 2024

[21828] Warn instead of fail when dds.communication.dynamic_interfaces cannot be built #5310

Merged

9 tasks

Mario-DL mentioned this pull request Oct 15, 2024

Error initializing Fast-DDS when the Ethernet link is not up #4371

Open

1 task

mergify bot mentioned this pull request Nov 7, 2024

[17283] Fix issues in Dynamic Network Interfaces (backport #5282) (backport #5304) #5390

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17283] Fix issues in Dynamic Network Interfaces #5282

[17283] Fix issues in Dynamic Network Interfaces #5282

MiguelCompany commented Sep 30, 2024 •

edited by JesusPoderoso

Loading

JesusPoderoso left a comment

MiguelCompany commented Oct 4, 2024

mergify bot commented Oct 4, 2024 •

edited

Loading

[17283] Fix issues in Dynamic Network Interfaces #5282

[17283] Fix issues in Dynamic Network Interfaces #5282

Conversation

MiguelCompany commented Sep 30, 2024 • edited by JesusPoderoso Loading

Description

Contributor Checklist

Reviewer Checklist

JesusPoderoso left a comment

Choose a reason for hiding this comment

MiguelCompany commented Oct 4, 2024

mergify bot commented Oct 4, 2024 • edited Loading

✅ Backports have been created

MiguelCompany commented Sep 30, 2024 •

edited by JesusPoderoso

Loading

mergify bot commented Oct 4, 2024 •

edited

Loading