Skip to content

[20641] Explicitly pass vendor ID to readFromCdrMessage #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 19, 2024

Description

With this PR, the incoming vendor ID is explicitly passed to the readFromCdrMessage function. By doing so, we avoid using the default value (Fast DDS), which can cause deserialization errors in case the incoming data uses a custom PID within the parameter list that we also happen to use for a different purpose. The PR adds a regression test, since CycloneDDS also uses PID 0x8007, but with a different content. Since the default vendor ID was being used, the deserialization of CycloneDDS Data(p) was failing.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.14.0 - Frozen milestone Mar 19, 2024
@EduPonz
Copy link
Author

EduPonz commented Mar 19, 2024

@richiprosima please test this

JesusPoderoso
JesusPoderoso previously approved these changes Mar 19, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link
Author

EduPonz commented Mar 19, 2024

@richiprosima please test this

@EduPonz EduPonz merged commit c5cd225 into master Mar 19, 2024
@EduPonz EduPonz deleted the feature/pass_vendor_id_to_readFromCdrMessage branch March 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants