[20641] Explicitly pass vendor ID to readFromCdrMessage #4583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, the incoming vendor ID is explicitly passed to the
readFromCdrMessage
function. By doing so, we avoid using the default value (Fast DDS), which can cause deserialization errors in case the incoming data uses a custom PID within the parameter list that we also happen to use for a different purpose. The PR adds a regression test, since CycloneDDS also uses PID 0x8007, but with a different content. Since the default vendor ID was being used, the deserialization of CycloneDDS Data(p) was failing.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist