Skip to content

[20165] Add tests for TypeLookup service #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Sep 25, 2024
Merged

[20165] Add tests for TypeLookup service #4339

merged 45 commits into from
Sep 25, 2024

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo commented Jan 31, 2024 •
edited by MiguelCompany
Loading

This PR adds:
Comunication tests for the TypeLookup service
Negative unit tests cases for the TypeLookup service

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 6046d94 to 8ea7ebb Compare January 31, 2024 06:52
@adriancampo adriancampo added the no-test Skip CI tests if PR marked with this label label Jan 31, 2024
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 8ea7ebb to 3bbfca2 Compare January 31, 2024 17:46
@adriancampo adriancampo marked this pull request as ready for review February 1, 2024 11:05
@JLBuenoLopez JLBuenoLopez mentioned this pull request Feb 8, 2024
Closed
9 tasks
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 3 times, most recently from 09ff409 to 5562797 Compare February 12, 2024 15:25
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 3 times, most recently from 070b1cd to 1bd6739 Compare February 19, 2024 15:06
@adriancampo adriancampo changed the base branch from feature/typelookup-listeners-implementation to feature/xtypes1.3 February 20, 2024 11:47
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 1bd6739 to 6c7ea6d Compare February 20, 2024 11:49
@EduPonz EduPonz added this to the v3.0.0 milestone Feb 21, 2024
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 4ee57ac to a477e2b Compare February 22, 2024 20:47
@adriancampo adriancampo changed the base branch from feature/xtypes1.3 to feature/typelookup-listeners-implementation February 22, 2024 20:48
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 2 times, most recently from a677d15 to 96bc6ff Compare February 23, 2024 10:34
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from b0e9647 to 99b6430 Compare February 28, 2024 06:50
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 96bc6ff to 0ac882a Compare February 28, 2024 16:16
@adriancampo adriancampo changed the base branch from feature/typelookup-listeners-implementation to feature/tests_for_dds_types_test February 28, 2024 16:17
@adriancampo adriancampo changed the base branch from feature/tests_for_dds_types_test to feature/typelookup-listeners-implementation February 28, 2024 16:18
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 640e7d7 to 09f6c70 Compare March 4, 2024 09:59
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 99b6430 to e03974e Compare March 6, 2024 14:28
@adriancampo adriancampo force-pushed the feature/typelookup-test branch from 09f6c70 to cd530f9 Compare March 6, 2024 19:26
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch from c9f8320 to f4e2ae9 Compare March 7, 2024 10:18
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch 2 times, most recently from 34997c9 to 8154de5 Compare March 18, 2024 15:00
adriancampo and others added 19 commits September 24, 2024 09:01
@adriancampo @richiware
Refs #20165: Removed willdcards from cmake.
6c6bddd 
Signed-off-by: adriancampo <[email protected]>
@adriancampo @richiware
Refs #20165: Updated types.
8834124 
Signed-off-by: adriancampo <[email protected]>
@adriancampo @richiware
Refs #20165: Fix for custom annotations name hash.
dec5d7e 
Signed-off-by: adriancampo <[email protected]>
@richiware
Refs #20165. Return typelookupservice unit tests
b28b9fb 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix for future rebase
46c747e 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Improve tests
3825749 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix typelookupservice builin endpoing discovery
0ee77c7 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Removed member_id testing
1b861d0 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix and improve tests
0cf0837 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Apply suggestions from code review
2313a11
@richiware
Refs #20165. Fix identation
f8ccba6 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix compilation error in mac
5c9c223 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix compilation errors
8bb5fe6 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Remove trace
80a2c1f 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fixes on windows
0a2b7c4 
Signed-off-by: Ricardo González <[email protected]>
@richiware
Refs #20165. Fixes after rebase
5f46f42 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fixes on mac
9b85819 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fixes asan
e73a278 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Apply suggestions
e7c0a00 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Fix minimal type_id built
5b5eaeb 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #20165. Apply suggestions
b548118 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the feature/typelookup-test branch from ff9a699 to b548118 Compare September 24, 2024 09:20
@richiware
Refs #20165. Apply suggestions
29daa05 
Signed-off-by: Ricardo González Moreno <[email protected]>
MiguelCompany
MiguelCompany approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@richiware richiware merged commit 309ae6f into master Sep 25, 2024
16 of 17 checks passed
@richiware richiware deleted the feature/typelookup-test branch September 25, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiware richiware Awaiting requested review from richiware

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.0.2 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
7 participants
@adriancampo @richiware @MiguelCompany @EduPonz @rsanchez15 @elianalf @Mario-DL