[20180] TCP Client&Server Participant Decision-Making #4277

cferreiragonz · 2024-01-23T15:19:14Z

Description

This pull request introduces a new heuristic in the communication logic for TCP participants, determining which participant will act as the client and which as the server when both are instantiated with one listening port. This logic is needed when using the LARGE_DATA builtin transports configuration.

To do this, a refactor on the TCP Sender Resource has been done. Now, Sender Resources will store a locator instead of a channel. Every time the participant tries to send a message through the TCP Sender Resource the locator will be used to check if it exists a channel inside the channel_resources_ map corresponding to the stored locator. If the search is successful, the message will be send, otherwise the message will be skiped.

This PR fixes the builtin transports tests included in #4098 related with TCP communications. It also includes a specific stress test for TCP, focusing on the "LARGE_DATA" topology.

@Mergifyio backport 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

MiguelCompany

Please document all new members / methods

test/blackbox/common/BlackboxTestsTransportTCP.cpp

src/cpp/rtps/attributes/RTPSParticipantAttributes.cpp

src/cpp/rtps/transport/TCPChannelResourceBasic.cpp

src/cpp/rtps/transport/TCPChannelResourceSecure.cpp

src/cpp/rtps/transport/ChannelResource.h

src/cpp/rtps/transport/TCPChannelResourceBasic.h

src/cpp/rtps/transport/TCPChannelResourceSecure.h

MiguelCompany

Partial review, pending tests:

I already applied and pushed some changes.

src/cpp/fastdds/publisher/DataWriterImpl.cpp

src/cpp/rtps/transport/TCPChannelResourceBasic.cpp

src/cpp/rtps/transport/TCPTransportInterface.cpp

src/cpp/rtps/transport/TCPChannelResource.h

src/cpp/rtps/transport/TCPTransportInterface.h

src/cpp/rtps/transport/TCPTransportInterface.cpp

src/cpp/rtps/transport/TCPTransportInterface.h

Signed-off-by: cferreiragonz <[email protected]>

… LARGE DATA Signed-off-by: cferreiragonz <[email protected]>

Signed-off-by: cferreiragonz <[email protected]>

… method Signed-off-by: cferreiragonz <[email protected]>

Signed-off-by: cferreiragonz <[email protected]>

Signed-off-by: Jesus Perez <[email protected]>

Signed-off-by: cferreiragonz <[email protected]>

MiguelCompany · 2024-02-13T21:17:34Z

@richiprosima Please test mac and test linux

…ntCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]>

…DATA. Signed-off-by: Miguel Company <[email protected]>

MiguelCompany · 2024-02-14T07:38:01Z

@richiprosima Please test mac and test linux

MiguelCompany · 2024-02-14T10:22:07Z

@richiprosima Please test mac

MiguelCompany · 2024-02-14T10:25:38Z

@richiprosima Please test mac

MiguelCompany · 2024-02-14T11:30:36Z

@richiprosima Please test windows

MiguelCompany · 2024-02-14T14:49:09Z

@Mergifyio backport 2.12.x 2.10.x 2.6.x

mergify · 2024-02-14T14:49:16Z

backport 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4384 [20180] TCP Client&Server Participant Decision-Making (backport #4277) has been created for branch 2.12.x but encountered conflicts
#4385 [20180] TCP Client&Server Participant Decision-Making (backport #4277) has been created for branch 2.10.x but encountered conflicts
#4386 [20180] TCP Client&Server Participant Decision-Making (backport #4277) has been created for branch 2.6.x but encountered conflicts

* Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140)

* TCP Client&Server Participant Decision-Making (#4277) * Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>

* Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* TCP Client&Server Participant Decision-Making (#4277) * Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>

#4413) * TCP Client&Server Participant Decision-Making (#4277) * Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts Signed-off-by: cferreiragonz <[email protected]> * Enabling multiple interfaces through whitelist in TCP servers (#4297) * Refs #20238: Add whitelist test in TCPv4 Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Add whitelist test in TCPv6 Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Adding interface to locator if whitelist is not empty Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Fix build in Windows Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Refs #20238: Remove repeated addition of listener port (added by default) Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 5f65a65) * Fix conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>

* Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140)

* TCP Client&Server Participant Decision-Making (#4277) * Refs #20180: Spelling fix Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Create function to check pending_logical_ports Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP Connection type Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new method to enable TCP channel after connection in LARGE DATA Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in processBindConnectionRequest method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add new TCP connection and methods SECURITY Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add SECURITY support to OpenOutputChannel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Bugfix setting environment variable in tests Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add multicast IPv6 to LARGE_DATA locator Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Add TCP test in LARGE_DATA Topology Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Clean code & Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Modified participant populated test Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add new api to update channels Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor OpenOutputChannel with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor bind_socket with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor SocketAccepted with new channel map (Revert to old behavior) Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor CloseOutputChannel to support cases with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Update Secure channel logic with new channel map Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Use same IPv6 as defaultMetatrafficMulticast Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Refactor using locator inside sender resource instead of channel Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Data races associated Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Apply suggestions to tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Add OpenLogicalPortRequest scenario before Bind Response is processed Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Remove unnecessary methods. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Early exit when logical_port is 0. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Refactor to avoid lambda. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Minor changes. Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Simplify with WanToLanLocator. Signed-off-by: Miguel Company <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP Connection type" This reverts commit 4b4eb4153553cfdbf007896ff524d3e904f722c9. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Remove unnecessary lock Signed-off-by: cferreiragonz <[email protected]> * Revert "Refs #20180: Add new TCP connection and methods SECURITY" This reverts commit c69d92e56dcfab3c3c7287145a7a93e57947d3cb. Signed-off-by: cferreiragonz <[email protected]> * Refs #20180: Fix test (file descriptors limit) Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20180. Fix port comparison. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]> * Refs #20180: Fix double lock and update old test with current behavior Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Fix windows test build Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Apply test suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20180: Bugfix with cv in receiver_resources_ destruction Signed-off-by: cferreiragonz <[email protected]> * Refs #20180. Delete participant on failing ParticipantTests.ParticipantCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]> * Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Jesus Perez <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 709b140) * Fix Conflicts Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Carlos Ferreira González <[email protected]>

cferreiragonz added this to the v2.13.2 milestone Jan 23, 2024

cferreiragonz requested a review from MiguelCompany January 23, 2024 15:19

cferreiragonz force-pushed the bugfix/client_server_tcp_decision_making branch from 96649d1 to ebfdcd9 Compare January 24, 2024 06:54

JesusPoderoso added the needs-review PR that is ready to be reviewed label Jan 29, 2024

EduPonz modified the milestones: v2.13.2, v2.13.3 Feb 1, 2024

MiguelCompany requested changes Feb 7, 2024

View reviewed changes

cferreiragonz force-pushed the bugfix/client_server_tcp_decision_making branch from 17648aa to 569b909 Compare February 9, 2024 07:18

jepemi mentioned this pull request Feb 9, 2024

[20120] TCPSendResources cleanup #4300

Merged

12 tasks

MiguelCompany requested changes Feb 9, 2024

View reviewed changes

cferreiragonz commented Feb 12, 2024

View reviewed changes

src/cpp/rtps/transport/TCPTransportInterface.cpp Outdated Show resolved Hide resolved

src/cpp/rtps/transport/TCPTransportInterface.h Show resolved Hide resolved

cferreiragonz and others added 17 commits February 12, 2024 09:47

Refs #20180: Spelling fix

913b444

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Create function to check pending_logical_ports

df1aa04

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add new TCP Connection type

794537d

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add new method to enable TCP channel after connection in…

c0de093

… LARGE DATA Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Refactor OpenOutputChannel method

69ebf24

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Include LARGE DATA logic in SocketAccepted method

10ee0ba

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Include LARGE DATA logic in processBindConnectionRequest…

fb6513c

… method Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add new TCP connection and methods SECURITY

d3ebda2

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add SECURITY support to OpenOutputChannel

9d4946f

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Include LARGE DATA logic in SecureSocketAccepted method

c25c0c8

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Bugfix setting environment variable in tests

ef04310

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add multicast IPv6 to LARGE_DATA locator

234a4c1

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Add TCP test in LARGE_DATA Topology

ef76564

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Clean code & Uncrustify

ef6d648

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Modified participant populated test

9024ce9

Signed-off-by: Jesus Perez <[email protected]>

Refs #20180: Add new api to update channels

102efdf

Signed-off-by: cferreiragonz <[email protected]>

Refs #20180: Refactor OpenOutputChannel with new channel map

1af4c93

Signed-off-by: cferreiragonz <[email protected]>

cferreiragonz dismissed MiguelCompany’s stale review via 2bae02a February 13, 2024 15:58

MiguelCompany previously approved these changes Feb 13, 2024

View reviewed changes

MiguelCompany added 2 commits February 14, 2024 08:36

Refs #20180. Delete participant on failing ParticipantTests.Participa…

51c099f

…ntCreationWithBuiltinTransport Signed-off-by: Miguel Company <[email protected]>

Refs #20180. Do not use non_blocking_send on TCP transport for LARGE_…

a4e6e3f

…DATA. Signed-off-by: Miguel Company <[email protected]>

MiguelCompany dismissed their stale review via a4e6e3f February 14, 2024 07:36

MiguelCompany approved these changes Feb 14, 2024

View reviewed changes

MiguelCompany merged commit 709b140 into master Feb 14, 2024

MiguelCompany deleted the bugfix/client_server_tcp_decision_making branch February 14, 2024 14:48

mergify bot mentioned this pull request Feb 14, 2024

[20180] TCP Client&Server Participant Decision-Making (backport #4277) #4384

Merged

mergify bot mentioned this pull request Feb 14, 2024

[20180] TCP Client&Server Participant Decision-Making (backport #4277) #4385

Merged

mergify bot mentioned this pull request Feb 14, 2024

[20180] TCP Client&Server Participant Decision-Making (backport #4277) #4386

Merged

MiguelCompany mentioned this pull request Mar 8, 2024

Fix lock_guard scope in DataWriterImpl::get_listener_for #4538

Draft

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20180] TCP Client&Server Participant Decision-Making #4277

[20180] TCP Client&Server Participant Decision-Making #4277

cferreiragonz commented Jan 23, 2024 •

edited by MiguelCompany

Loading

MiguelCompany left a comment

MiguelCompany left a comment

MiguelCompany commented Feb 13, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

mergify bot commented Feb 14, 2024 •

edited

Loading

[20180] TCP Client&Server Participant Decision-Making #4277

[20180] TCP Client&Server Participant Decision-Making #4277

Conversation

cferreiragonz commented Jan 23, 2024 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany commented Feb 13, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

MiguelCompany commented Feb 14, 2024

mergify bot commented Feb 14, 2024 • edited Loading

✅ Backports have been created

cferreiragonz commented Jan 23, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Feb 14, 2024 •

edited

Loading