-
Notifications
You must be signed in to change notification settings - Fork 817
[20086] Methods to configure transport scenarios (backport #4098) #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@richiprosima please test this |
* Revert "TCP deadlock on channel reuse (#4099)" This reverts commit dd4c434. Signed-off-by: EduPonz <[email protected]> * Refs #20055: Separate builtin transports tests into individual cases Signed-off-by: EduPonz <[email protected]> * Refs #20055: Mark large_data tests as flaky due to TCP Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit 5e87eb3)
@richiprosima please test this |
d254e26
to
639c6e9
Compare
@richiprosima please test this |
I ordered a manual Sanitizer analysis here since it seems to consistently complain in these backports despite test errors seems unrelated |
@richiprosima please test mac |
Ordering a manual Sanitizer analysis here just in case the |
@richiprosima please test mac |
IMO There are some leaks that seems related to this PR that we should take a look at |
Ordering here a new Sanitizer run on this PR. This time I am using the |
This PR introduced tests fail in Windows CI (both Github actions and Jenkins) |
* Refs #20020. Added enumeration for possible builtin transports configuration. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Add method to parse environment variable. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Cleanup RTPSParticipantAttributes.h. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Moved default transports configuration into RTPSParticipantAttributes::setup_transports. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. RTPSParticipantImpl constructor uses private copy of attributes. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for DEFAULTv6. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. SHM transport added before UDP. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for SHM. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for UDPv4. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for UDPv6. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Factor out duplicated code. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for LARGE_DATA. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added support for LARGE_DATAv6. Signed-off-by: Miguel Company <[email protected]> * Refs #20020. Added DomainParticipantQos::setup_transports. Signed-off-by: Miguel Company <[email protected]> * Refs #20020: Add constants for builtin transports Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add XML parser functions for builtin_transports Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: add builtinTransports to .xsd Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: add mock tests needed Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add builtin transports XML file Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add new API to tests classes Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add Blackbox tests Signed-off-by: cferreiragonz <[email protected]> * Refs 20020: Rename XML file and EOF Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add unittest test Signed-off-by: elianalf <[email protected]> * Refs #20020: Update versions.md Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Make enum uint16_t Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add Parsing test Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Apply minor changes Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Remove - in CMakeLists Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Fix .xsd and remove unnecesary mock test Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Add implementation for mock test Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Fix windows build Signed-off-by: cferreiragonz <[email protected]> * Refs #20020: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Disable v6 tests for Mac Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: elianalf <[email protected]> Co-authored-by: cferreiragonz <[email protected]> Co-authored-by: elianalf <[email protected]> (cherry picked from commit 8cbd461) # Conflicts: # include/fastdds/dds/domain/qos/DomainParticipantQos.hpp # include/fastdds/rtps/attributes/RTPSParticipantAttributes.h # include/fastrtps/xmlparser/XMLParser.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # src/cpp/rtps/xmlparser/XMLElementParser.cpp # test/unittest/dynamic_types/CMakeLists.txt # test/unittest/statistics/dds/CMakeLists.txt # test/unittest/xmlparser/CMakeLists.txt # versions.md
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
639c6e9
to
004ebdd
Compare
This PR has been rebased on top of To properly compare the CI. Changing PR base accordingly |
@richiprosima please test this |
The errors in the asan job are 3 instances of the same error (a leak in the SecurityManager) which is not related to the changes in this PR. Other failures seem unrelated |
This is an automatic backport of pull request #4098 done by Mergify.
Cherry-pick of 8cbd461 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com